Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run etcd 2.0.5 in a pod #6221

Merged
merged 1 commit into from Apr 1, 2015
Merged

Run etcd 2.0.5 in a pod #6221

merged 1 commit into from Apr 1, 2015

Conversation

ArtfulCoder
Copy link
Contributor

@zmerlynn

This PR should work correctly since we added some robustness to kube-addons creation logic with the retries #6200

"containers":[
{
"name": "etcd-container",
"image": "kubernetes/etcd:2.0.5.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this image on ContainerVM now, or should we get it onto gcr.io?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in ContainerVM image since we still support other internal users.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with merge as-is so we can start to get some run-time. Can you file a follow-on issue to move this to gcr.io quickly, though, so all infrastructure is off docker hub?

@zmerlynn
Copy link
Member

LGTM except that question.

@dchen1107
Copy link
Member

LGTM. Can you run e2e test against this change?

@dchen1107
Copy link
Member

This is revert-of-revert-of-#4442

@dchen1107
Copy link
Member

Please run e2e tests and post the result here. Network test was failed due to

  1. Networking test timing out on Jenkins #5629 (comment)
    which is fixed in test itself.

  2. apiserver is not response

@ArtfulCoder
Copy link
Contributor Author

Summarizing 5 Failures:

Fail] 90mPD It] should schedule a pod w/ a RW PD, remove it, then schedule it on another host
37m/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/pd.go:107

(Failed to delete PD)

Fail] 90mkubectl update-demo It] should scale a replication controller
37m/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/util.go:264

Fail] 90mDensity It] should allow starting 30 pods per node
37m/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:175

Apparently pods didnt start up

Fail] 90mShell It] tests that services.sh passes
37m/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/shell.go:67

Fail] 90mSecrets It] should be consumable from pods
37m/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/secrets.go:111
Failed, waiting for pods to come up.

Ran 28 of 32 Specs in 5036.928 seconds
FAIL! -- 32m23 Passed | 5 Failed | 1 Pending | 3 Skipped

@ArtfulCoder
Copy link
Contributor Author

My second test run finished
There were two failures, both related to PD tests
[It] verify monitoring pods and all cluster nodes are available on influxdb using heapster.

INFO: failed to query list of pods from influxdb. Query: "select distinct(pod_id) from /cpu./", Err: expected only one series from Influxdb for query "select distinct(pod_id) from /cpu./". Got []

[It] should schedule a pod w/ a RW PD, remove it, then schedule it on another host
INFO: Couldn't delete PD. Sleeping 5 seconds

@ArtfulCoder
Copy link
Contributor Author

of the two, the first is failing on HEAD as well.

The second is failing on a "gcloud compute disks delete" command even after though the pod holding the pd has been killed.

I believe these are not related to my change.
So we should be good to go to merge this change.

@timothysc
Copy link
Member

@eparis ^ FYI.

@zmerlynn
Copy link
Member

zmerlynn commented Apr 1, 2015

Merging to get some soak time in Jenkins.

zmerlynn added a commit that referenced this pull request Apr 1, 2015
@zmerlynn zmerlynn merged commit 8078a6a into kubernetes:master Apr 1, 2015
@dchen1107
Copy link
Member

Great!

@eparis
Copy link
Contributor

eparis commented Apr 1, 2015

@aveshagarwal

Can you check out how he docker-i-fied etcd and see if there is anything here we want to grab/contribute?

@aveshagarwal
Copy link
Member

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants