Running etcd 2.0.5 in a pod on master #6218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @zmerlynn @dchen1107 |
|
I think something is wrong with your tree here? That "merge" commit is bogus. |
|
Rather, even if this is a merge, I'd much rather merge a PR that's a clean commit than a merge commit. I just worked out that this PR is a merge commit, so we'd be merging a merge commit. |
|
yes, I am going to just close this PR and create a new one. |
|
You probably could've cleaned out your branch and still pushed to this PR, but either way. :) |
|
created #6221 |
|
Why not simply revert previous revert one? Just curious here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #6200 The kube-addons come up now since retry logic is added to create kube-addons.
This PR should work now robustly.