-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support recovery for anonymous roll outs #7407
Conversation
What is this PR trying to fix/change? |
Right now, if you cancel a If you use an "anonymous" roll out (that is one for which the second controller is automatically generated with a hashed name) it may not recover correctly, because it doesn't know the name of the previous "next" controller, so we add an annotation to the "old" controller to make the "next" controller discoverable. Thanks |
2969788
to
4a6f53f
Compare
Looks good. Will take second look after #7279 is merged. |
cc @ironcladlou
|
needs rebase |
It's rebased and good to go (shippable is a flake, and I'm hitting it again) |
4a6f53f
to
83cbd0c
Compare
lgtm |
Support recovery for anonymous roll outs
@jlowdermilk @bgrant0607 @smarterclayton @deads2k @ghodss
Builds off of #7279 please only review the 2nd commit.