-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster/gce/coreos: Add metadata-service in node.yaml #7526
Conversation
Also this one uses the 0.5.4 version rkt metadata service. |
lgtm |
LGTM, any reason to run them this way instead of how we did before? |
@vmarmol One is we were not running the new version of rkt metadata service. Two is I think named service is more manageable. And three is it's now socket activated. |
Did you get a chance to test btw? While we wait for Travis |
@vmarmol Yes, I will run e2e |
More than anything that the CoreOS cluster comes up :) @dchen1107 had the instructions in her PR |
e2e agains gce/debian passed:
build/push-devel-build.sh passed:
Running e2e agains gce/coreos |
FWIW, don't worry too much about the push-devel-build part. I was merely pointing that out in her PR because of a breaking issue in the release flow I noticed there. In typical changes (i.e. not renaming a cluster/* file), it's not something you need to run. |
@zmerlynn Sounds good! Thanks! |
Yeah I don't think we have :) there are some tests that are Docker-specific so I wouldn't expect them to pass just yet. I think we're good with this PR, will merge. Thanks @yifan-gu! |
Thanks @vmarmol ! |
cluster/gce/coreos: Add metadata-service in node.yaml
/cc @dchen1107 @vmarmol @jonboulle @bakins
Actually I found the metadata service is already started in old node.yaml, just updated with more specific service/socket files.
This saves us from start
metadata service
manually in #7465