kubelet/rkt: Add podInfo. #7555
Conversation
| status.PodIP = p.getIP() | ||
| // For now just make every container's state as same as the pod. | ||
| for _, container := range pod.Containers { | ||
| status.ContainerStatuses = append(status.ContainerStatuses, p.getContainerStatus(container)) |
There was a problem hiding this comment.
Is this actually just using the pod status? Looks like we do get per-container status
There was a problem hiding this comment.
Containers are sharing fate at this moment, so they have the same status. This is something under hot discussion. Should be more clearer in the following weeks:
appc/spec#276
| state string | ||
| // The ip of the pod. IPv4 for now. | ||
| ip string | ||
| networkInfo string |
yifan-gu
force-pushed
the
rkt_pod_info
branch
3 times, most recently
from
8c50615
to
74f1452
Compare
|
@vmarmol Rebased and also moved |
|
|
||
| // splitLineByTab breaks a line by tabs, and trims the leading and tailing spaces. | ||
| // Not using strings.Split because there could be multiple tabs. | ||
| func splitLineByTab(line string) []string { |
There was a problem hiding this comment.
Alternatively: Split on tabs and remove all empty strings in the slice. May be simpler to implement and reason about.
podInfo reprensents the state of rkt pods. It is used to for reporting the pod and container status to kubelet.
|
Thanks for the thorough review! @vmarmol ! |
|
LGTM |
|
LGTM, thanks for the quick changes @yifan-gu! |
| type containerID struct { | ||
| uuid string // uuid of the pod. | ||
| appName string // name of the app in that pod. | ||
| imageID string // id of the image. TODO(yifan): Depreciate this. |
|
Good to go on this one? |
|
@jonboulle yep, just waiting on the CI (which is taking so much longer than I'd like :( ) |
|
It's green! |
|
awesome! |
@vmarmol @dchen1107 @jonboulle @bakins
Another shot following #7465
This adds podInfo, which represents the rkt pod's state, and is used for reporting pod/container status to kubelet.
Think we have about three more PRs after this for implementing syncPod for rkt!