Adds a simple release-note builder that scrapes the Github API for recent PRs #7616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| GOPATH=$PWD go get github.com/google/go-querystring | ||
| GOPATH=$PWD go build release-notes.go | ||
|
|
||
| ./release-notes --laste-release-pr=<pr # of the previous release> |
There was a problem hiding this comment.
should be "last-release-pr"
| exit 1 | ||
| fi | ||
|
|
||
| set -o nounset |
There was a problem hiding this comment.
please move this to the top and use [[ -z "${1:-}" ]]; in the above check.
|
Travis and shippable are both unhappy with your change, failing trying to install godeps. Maybe you need to bite the bullet now and get the dependencies into our godeps tree.... |
brendandburns
force-pushed
the
qps
branch
5 times, most recently
from
223228a
to
fce355f
Compare
|
@roberthbailey does this look good to merge? Shippable failure is a flake. |
|
Yes. LGTM. |
roberthbailey
added a commit
that referenced
this pull request
May 7, 2015
Adds a simple release-note builder that scrapes the Github API for recent PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roberthbailey
Closes #6213
Possibly worth automating further, but this will help standardize and organize.