Set GOMAXPROCS for etcd #7863
Merged
Set GOMAXPROCS for etcd #7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,5 @@ | |||
| {% set num_nodes = salt['grains.get']('num_cpus', '') %} | |||
There was a problem hiding this comment.
Oops :) I copy&pasted this line from an example and forgot to change the variable name. Thanks!
fgrzadkowski
force-pushed
the
etcd_maxprocs
branch
from
b7a57bb
to
7e8bde5
Compare
|
LGTM |
wojtek-t
added
the
lgtm
|
kind of sledgehammering it, ideally it would be good to know optimal values. |
|
@timothysc optimal value probably depends on the number of cores & workload; this seems like a good guess. When I've tried optimizing GOMAXPROCS for other go programs, number of cpus+1 seemed the best. But etcd could be very different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7767
@timothysc @wojtek-t