update mysql-wordpress example to use v1beta3 API #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # the port that this service should serve on | ||
| - port: 3306 | ||
| # the port to access on the pods targeted by the service | ||
| targetPort: 3306 |
There was a problem hiding this comment.
targetPort is not required if it is same as port
|
LGTM module a nit |
caesarxuchao
force-pushed
the
wordpress-example
branch
from
7a69b52
to
284cd20
Compare
|
Hi @nikhiljindal, I remove the "targetPort", could you take a look? Thanks. |
|
LGTM, thanks! |
nikhiljindal
added a commit
that referenced
this pull request
May 7, 2015
update mysql-wordpress example to use v1beta3 API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikhiljindal
update mysql-wordpress example to use v1beta3 API