-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update example/walkthrough to v1beta3 #7940
update example/walkthrough to v1beta3 #7940
Conversation
``` | ||
|
||
Ok, so what did we do? We added a volume to our pod: | ||
|
||
Ok, so what did we do? We added a volume of our pod: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a volume "to" pod seems better than volume "of" pod
LGTM, modulo a few nits. You should also update the PR title to something more appropriate like "Updating examples/walkthrough to use v1beta3 configs" |
a6ffec4
to
e20adfd
Compare
@nikhiljindal, thanks. |
e20adfd
to
ab356c9
Compare
Shippable is still red. |
@nikhiljindal Do you know why the first build failed but the second on was successful? |
I didn't change anything but shippable is green now |
It had timedout last time. I restarted it and it is green now. |
update example/walkthrough to v1beta3
# an http probe | ||
httpGet: | ||
path: /_status/healthz | ||
port: 8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't match the exposed containerPort (80)
I have verified that all the v1beta3 yaml files are working properly @nikhiljindal