fix: add required to relevant properties

GoogleCloudPlatform · Jan 5, 2024 · 7ccd199 · 7ccd199
1 parent feecc38
commit 7ccd199
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/mmv1/products/cloudrunv2/Service.yaml b/mmv1/products/cloudrunv2/Service.yaml
@@ -765,22 +765,27 @@ properties:
                 - !ruby/object:Api::Type::String
                   name: bucket
                   description: GCS Bucket name
+                  required: true
                 - !ruby/object:Api::Type::Boolean
                   name: readOnly
                   description: If true, mount the GCS bucket as read-only
+                  required: false
             - !ruby/object:Api::Type::NestedObject
               name: nfs
               description: Represents an NFS mount.
               properties:
                 - !ruby/object:Api::Type::String
                   name: server
                   description: Hostname or IP address of the NFS server
+                  required: true
                 - !ruby/object:Api::Type::String
                   name: path
                   description: Path that is exported by the NFS server.
+                  required: true
                 - !ruby/object:Api::Type::Boolean
                   name: readOnly
                   description: If true, mount the NFS volume as read only
+                  required: false
       - !ruby/object:Api::Type::Enum
         name: 'executionEnvironment'
         description: |-

diff --git a/mmv1/templates/terraform/examples/cloudrunv2_service_mount_gcs.tf.erb b/mmv1/templates/terraform/examples/cloudrunv2_service_mount_gcs.tf.erb
@@ -10,8 +10,9 @@ resource "google_cloud_run_v2_service" "<%= ctx[:primary_resource_id] %>" {
     containers {
       image = "us-docker.pkg.dev/cloudrun/container/hello"
       volume_mounts {
-        name = "bucket"
+        name       = "bucket"
         mount_path = "/var/www"
+        read_only  = false
       }
     }
 

diff --git a/mmv1/templates/terraform/examples/cloudrunv2_service_mount_nfs.tf.erb b/mmv1/templates/terraform/examples/cloudrunv2_service_mount_nfs.tf.erb
@@ -24,8 +24,9 @@ resource "google_cloud_run_v2_service" "<%= ctx[:primary_resource_id] %>" {
     volumes {
       name = "nfs"
       nfs {
-        server = google_filestore_instance.default.networks[0].ip_addresses[0]
-        path   = "/share1"
+        server    = google_filestore_instance.default.networks[0].ip_addresses[0]
+        path      = "/share1"
+        read_only = false
       }
     }
   }