Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error messages when mmv1 compilation fails #10191

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Improve the error messages when mmv1 compilation fails #10191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mmv1/compiler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@
)
resource.validate
resources.push(resource)
rescue StandardError => e
Google::LOGGER.error "Failed to compile #{file_path}: #{e}"
raise e
end

if override_dir
Expand Down Expand Up @@ -221,6 +224,9 @@
)
resource.validate
resources.push(resource)
rescue StandardError => e
Google::LOGGER.error "Failed to compile using override #{override_path}: #{e}"
raise e
end
end
resources = resources.sort_by(&:name)
Expand Down