Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance test for name_from_id function #10262

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

SarahFrench
Copy link
Collaborator

@SarahFrench SarahFrench commented Mar 22, 2024

Fixes the config used for the affected acceptance test. There was a copy paste error missed in review.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3528
Passed tests: 3154
Skipped tests: 365
Affected tests: 9

Click here to see the affected service packages
all service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaseAndroidApp_update|TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUnenforcedExample|TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUpdate|TestAccFirestoreIndex_firestoreIndexBasicExample|TestAccFirestoreIndex_firestoreIndexDatastoreModeExample|TestAccNetappkmsconfig_kmsConfigCreateExample_Update|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstationConfig_updateHostDetails

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFirebaseAndroidApp_update[Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUnenforcedExample[Debug log]
TestAccFirebaseAppCheckServiceConfig_firebaseAppCheckServiceConfigUpdate[Debug log]
TestAccFirestoreIndex_firestoreIndexBasicExample[Debug log]
TestAccNetappkmsconfig_kmsConfigCreateExample_Update[Debug log]
TestAccNotebooksInstance_notebookInstanceFullExample[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]
TestAccWorkstationsWorkstationConfig_updateHostDetails[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFirestoreIndex_firestoreIndexDatastoreModeExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@SarahFrench
Copy link
Collaborator Author

TestAccFirestoreIndex_firestoreIndexDatastoreModeExample

This test failure is unrelated to this PR; merging. Thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants