Add support for google_compute_url_map to TGC

[kotarsky]

adding support for compute.googleapis.com/UrlMap

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[rileykarson]

There's a mismatch between the release note and PR title and the change you've made. Do you have a bug or issue you can link for context?

[kotarsky]

There's a mismatch between the release note and PR title and the change you've made. Do you have a bug or issue you can link for context?

You're right, just edited the release note and fixed it.
Actually, I'm just working on some tests related to some assets. You can expect more PRs from me in the next few days.
Thanks for the review!

[rileykarson]

For this & other related PRs the title should cover the actual end result of the change- we're adding new resources to terraform-google-conversion, not adding new tests for that.

I'd ask that we title these as "Add support for {{resource}} to TGC" i.e. "Add support for google_compute_url_map to TGC".

Your changelog is typed none, which is correct, as this has no impact on provider users. We should blank them out as well, for clarity.

Running build to ensure we're running the new tests correctly.

[rileykarson]

For this & other related PRs the title should cover the actual end result of the change- we're adding new resources to terraform-google-conversion, not adding new tests for that.

I'd ask that we title these as "Add support for {{resource}} to TGC" i.e. "Add support for google_compute_url_map to TGC".

Your changelog is typed none, which is correct, as this has no impact on provider users. We should blank them out as well, for clarity.

Running build to ensure we're running the new tests correctly.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 75 insertions(+))

[dvfons]

/gcbrun

[rileykarson]

@dvfons: I'm seeing a CLA issue on your new commit, can you resolve that? Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 75 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 75 insertions(+))

[kotarsky]

all tests fixed

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 5 files changed, 78 insertions(+))

[github-actions]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 7 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

[kotarsky]

@rileykarson Can you review it again?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 5 files changed, 78 insertions(+))

[github-actions]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.