Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new compute network to fix dbms private connection test #10738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented May 20, 2024

Fixes #17384

Since the test itself relies on a default network it attempts to use an ip address that has already been reserved resulting in an operation timeout. Solution Reference: hashicorp/terraform-provider-google#17384 (comment)

The chosen subnet ip comes from the docs themselves since we're using auto_create_subnetworks: https://cloud.google.com/vpc/docs/vpc#ip-ranges

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 2 files changed, 14 insertions(+), 9 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 7 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • databasemigrationservice

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants