Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace f1-micro with g1-small to speed up tests. #10743

Merged
merged 1 commit into from
May 20, 2024

Conversation

algawivem
Copy link
Contributor

@algawivem algawivem commented May 20, 2024

hashicorp/terraform-provider-google#13603
Setting f1 micro tier may result in slowness, use g1 small to speed up tests.

Release Note Template for Downstream PRs (will be copied)


Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 45 insertions(+), 45 deletions(-))
google-beta provider: Diff ( 1 file changed, 45 insertions(+), 45 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 93
Passed tests: 45
Skipped tests: 15
Affected tests: 33

Click here to see the affected service packages
  • sql

Action taken

Found 33 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSqlDatabaseInstance_BackupRetention|TestAccSqlDatabaseInstance_activationPolicy|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_insights|TestAccSqlDatabaseInstance_maintenance|TestAccSqlDatabaseInstance_maintenanceVersion|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample|TestAccSqlDatabaseInstance_updateDifferentFlagOrder|TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled|TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL|TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject|TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled|TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSqlDatabaseInstance_BackupRetention[Debug log]
TestAccSqlDatabaseInstance_activationPolicy[Debug log]
TestAccSqlDatabaseInstance_authNets[Debug log]
TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled[Debug log]
TestAccSqlDatabaseInstance_basicSecondGen[Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels[Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Debug log]
TestAccSqlDatabaseInstance_diskspecs[Debug log]
TestAccSqlDatabaseInstance_highAvailability[Debug log]
TestAccSqlDatabaseInstance_insights[Debug log]
TestAccSqlDatabaseInstance_maintenance[Debug log]
TestAccSqlDatabaseInstance_maintenanceVersion[Debug log]
TestAccSqlDatabaseInstance_multipleOperations[Debug log]
TestAccSqlDatabaseInstance_settingsDowngrade[Debug log]
TestAccSqlDatabaseInstance_settings_basic[Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection[Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled[Debug log]
TestAccSqlDatabaseInstance_settings_secondary[Debug log]
TestAccSqlDatabaseInstance_settings_upgrade[Debug log]
TestAccSqlDatabaseInstance_slave[Debug log]
TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample[Debug log]
TestAccSqlDatabaseInstance_updateDifferentFlagOrder[Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled[Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled[Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@rileykarson rileykarson merged commit 755b0ee into GoogleCloudPlatform:main May 20, 2024
12 of 13 checks passed
avijain25 pushed a commit to avijain25/magic-modules that referenced this pull request May 21, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants