adding support for Cloud Dataplex Entry Type resource.

[avijain25]

Adding Terraform support for a Dataplex Entry Type resource.
Tracking issue: hashicorp/terraform-provider-google#18146

`google_dataplex_entry_type`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1844 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1844 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 532 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_entry_type (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type" "primary" {
  platform = # value needed
  required_aspects {
    type = # value needed
  }
  system       = # value needed
  type_aliases = # value needed
}

Resource: google_dataplex_entry_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_entry_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 38
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages

• dataplex

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexEntryTypeIamBindingGenerated|TestAccDataplexEntryTypeIamMemberGenerated|TestAccDataplexEntryTypeIamPolicyGenerated|TestAccDataplexEntryType_dataplexEntryTypeBasicExample|TestAccDataplexEntryType_dataplexEntryTypeFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexEntryTypeIamBindingGenerated[Debug log]
TestAccDataplexEntryTypeIamMemberGenerated[Debug log]
TestAccDataplexEntryTypeIamPolicyGenerated[Debug log]
TestAccDataplexEntryType_dataplexEntryTypeBasicExample[Debug log]
TestAccDataplexEntryType_dataplexEntryTypeFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1864 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1864 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 532 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_entry_type (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type" "primary" {
  required_aspects {
    type = # value needed
  }
}

Resource: google_dataplex_entry_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_entry_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 42
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexEntryType_dataplexEntryTypeFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexEntryType_dataplexEntryTypeFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1888 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1888 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 532 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_entry_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_entry_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 42
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexEntryType_dataplexEntryTypeFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexEntryType_dataplexEntryTypeFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1926 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1926 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 532 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_entry_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_entry_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 42
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexEntryType_dataplexEntryTypeFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexEntryType_dataplexEntryTypeFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2038 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 2038 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 532 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_entry_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_entry_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• dataplex

Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccDataplexEntryTypeIamBindingGenerated
• TestAccDataplexEntryTypeIamMemberGenerated
• TestAccDataplexEntryTypeIamPolicyGenerated
• TestAccDataplexEntryType_dataplexEntryTypeBasicExample
• TestAccDataplexEntryType_dataplexEntryTypeFullExample
• TestAccDataplexEntryType_update

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2038 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 2038 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 532 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_entry_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_entry_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2038 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 2038 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 532 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_entry_type_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_entry_type_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_entry_type_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 43
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexEntryType_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexEntryType_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 43
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexEntryType_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexEntryType_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[SarahFrench]

Hi @avijain25, thanks for your PR! The tests look comprehensive and are passing, but before approving I would usually compare API documentation to the contents of mmv1/products/dataplex/EntryType.yaml to check for errors. I can find any public-facing documentation for this new resource - is any available?

Note: I'm going to ignore the missing test detector message here about IAM-related resources; those tests are generated so aren't in scope for this PR.

[avijain25]

Hi @avijain25, thanks for your PR! The tests look comprehensive and are passing, but before approving I would usually compare API documentation to the contents of mmv1/products/dataplex/EntryType.yaml to check for errors. I can find any public-facing documentation for this new resource - is any available?

Note: I'm going to ignore the missing test detector message here about IAM-related resources; those tests are generated so aren't in scope for this PR.

Similar PRs for the same GA release(just for reference):
#10721
#10751
#10756

Looking for public documentation.

[avijain25]

@SarahFrench Thanks for the review. We are still working on the public documentations for the feature.

However, this is our client library reference.

We want to merge the PR by end of this week, so that terraform integration can make it to our GA release(May end).

[SarahFrench]

Approving based on tests passing 🚢