Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Managed Kafka Topic resource and tests. #10774

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

jessdejong
Copy link
Member

@jessdejong jessdejong commented May 23, 2024

Description: Adding a new Managed Kafka Topic terraform resource to terraform-provider-google-beta. Includes a basic create and update test.

Issue: https://b.corp.google.com/issues/322841720

`google_managed_kafka_topic` (beta)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 623 insertions(+))
google-beta provider: Diff ( 18 files changed, 2607 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_managed_kafka_cluster (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_managed_kafka_cluster" "primary" {
  gcp_config {
    kms_key = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3703
Passed tests: 3327
Skipped tests: 371
Affected tests: 5

Click here to see the affected service packages
all service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update|TestAccManagedKafkaCluster_managedkafkaClusterBasicExample|TestAccManagedKafkaCluster_update|TestAccManagedKafkaTopic_managedkafkaTopicBasicExample|TestAccManagedKafkaTopic_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccManagedKafkaCluster_managedkafkaClusterBasicExample[Error message] [Debug log]
TestAccManagedKafkaCluster_update[Error message] [Debug log]
TestAccManagedKafkaTopic_managedkafkaTopicBasicExample[Error message] [Debug log]
TestAccManagedKafkaTopic_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 443 insertions(+))
google-beta provider: Diff ( 18 files changed, 2741 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3722
Passed tests: 2838
Skipped tests: 373
Affected tests: 511

Click here to see the affected service packages
all service packages are affected

Action taken

Found 511 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAccessApprovalSettings|TestAccAccessContextManager|TestAccAlloydbBackup_alloydbBackupBasicTestExample|TestAccAlloydbBackup_update|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable|TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccAlloydbCluster_alloydbSecondaryClusterBasicTestExample|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable|TestAccAlloydbCluster_continuousBackup_enabledByDefault|TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved|TestAccAlloydbCluster_continuousBackup_update|TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_missingWeeklySchedule|TestAccAlloydbCluster_restore|TestAccAlloydbCluster_secondaryClusterPromote|TestAccAlloydbCluster_secondaryClusterPromoteAndAddAndDeleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_secondaryClusterPromoteAndAddContinuousBackupConfig|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteOriginalPrimary|TestAccAlloydbCluster_secondaryClusterPromoteAndDeleteTimeBasedRetentionPolicy|TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate|TestAccAlloydbCluster_secondaryClusterPromoteAndUpdate|TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_update|TestAccAlloydbCluster_usingCMEK|TestAccAlloydbCluster_withMaintenanceWindows|TestAccAlloydbCluster_withNetworkConfig|TestAccAlloydbCluster_withNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_alloydbInstanceBasicTestExample|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample|TestAccAlloydbInstance_clientConnectionConfig|TestAccAlloydbInstance_networkConfig|TestAccAlloydbInstance_secondaryInstanceMaximumFields|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig|TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccAlloydbInstance_update|TestAccAlloydbUser_alloydbUserBuiltinTestExample|TestAccAlloydbUser_alloydbUserIamTestExample|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_updateRoles_IAM|TestAccArtifactRegistryRepository_artifactRegistryRepositoryCmekExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteDockerCustomWithAuthExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteDockerhubAuthExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteMavenCustomWithAuthExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteNpmCustomWithAuthExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemotePythonCustomWithAuthExample|TestAccBigQueryDataset_cmek|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigQueryTable_Kms|TestAccBigqueryDataTransferConfig|TestAccBillingBudget_billingBudgetBasicExample|TestAccBillingBudget_billingBudgetCustomperiodExample|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingBudgetLastperiodExample|TestAccBillingBudget_billingBudgetNotifyExample|TestAccBillingBudget_billingBudgetOptionalExample|TestAccBillingBudget_billingBudgetUpdate|TestAccBillingBudget_billingFilterSubaccounts|TestAccBillingBudget_budgetFilterProjectsOrdering|TestAccBinaryAuthorizationAttestor_kms|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample|TestAccCloudAssetProjectFeed_cloudAssetProjectFeedExample|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_webhook_config|TestAccCloudFunctionsFunction_dockerRepository|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudIdsEndpoint_basic|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccCloudSchedulerJob_schedulerJobOauthExample|TestAccCloudSchedulerJob_schedulerJobOidcExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccComposer1Environment_withNodeConfig|TestAccComposer2Environment_withNodeConfig|TestAccComposerEnvironment_fixPyPiPackages|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComputeAddress_instanceWithIpExample|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeDisk_cloneDisk|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_encryptionKMS|TestAccComputeDisk_fromSnapshot|TestAccComputeDisk_fromTypeUrl|TestAccComputeDisk_multiWriter|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_update|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeImage_basedondisk|TestAccComputeImage_imageEncryptionKey|TestAccComputeImage_sourceImage|TestAccComputeImage_sourceSnapshot|TestAccComputeImage_withLicense|TestAccComputeInstanceGroup_basic|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstanceTemplate_EncryptKMS|TestAccComputeInstanceTemplate_IP|TestAccComputeInstanceTemplate_IPv6|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccComputeInstanceTemplate_basic|TestAccComputeInstanceTemplate_diskIops|TestAccComputeInstanceTemplate_diskResourcePolicies|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_enableDisplay|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_instanceResourcePolicies|TestAccComputeInstanceTemplate_localSsdRecoveryTimeout|TestAccComputeInstanceTemplate_maintenance_interval|TestAccComputeInstanceTemplate_managedEnvoy|TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_networkIP|TestAccComputeInstanceTemplate_networkIPAddress|TestAccComputeInstanceTemplate_networkTier|TestAccComputeInstanceTemplate_preemptible|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_reservationAffinities|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstanceTemplate_soleTenantNodeAffinities|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey|TestAccComputeInstanceTemplate_spot|TestAccComputeInstanceTemplate_spot_maxRunDuration|TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction|TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeInstance_IPv6|TestAccComputeInstance_NetworkAttachmentUpdate|TestAccComputeInstance_NicStackTypeUpdate|TestAccComputeInstance_PTRRecord|TestAccComputeInstance_advancedMachineFeatures|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_basic1|TestAccComputeInstance_bootDisk_mode|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_confidentialHyperDiskBootDisk|TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse|TestAccComputeInstance_enableDisplay|TestAccComputeInstance_forceChangeMachineTypeManually|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_hostname|TestAccComputeInstance_hyperdiskBootDisk_provisioned_iops_throughput|TestAccComputeInstance_internalIPv6|TestAccComputeInstance_ipv6ExternalReservation|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_localSsdRecoveryTimeout|TestAccComputeInstance_localSsdRecoveryTimeout_update|TestAccComputeInstance_maxRunDuration_update|TestAccComputeInstance_minCpuPlatform|TestAccComputeInstance_multiNic|TestAccComputeInstance_networkTier|TestAccComputeInstance_primaryAliasIpRange|TestAccComputeInstance_queueCount|TestAccComputeInstance_reservationAffinities|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeInstance_scheduling|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeInstance_serviceAccount|TestAccComputeInstance_serviceAccount_updated|TestAccComputeInstance_serviceAccount_updated0to1to0scopes|TestAccComputeInstance_shieldedVmConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_spotVM|TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction|TestAccComputeInstance_spotVM_maxRunDuration_update|TestAccComputeInstance_spotVM_update|TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction|TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction|TestAccComputeInstance_stopInstanceToUpdate|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_subnetworkUpdate|TestAccComputeInstance_with375GbScratchDisk|TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample|TestAccComputeInterconnect_computeInterconnectBasicTestExample|TestAccComputeNodeTemplate_nodeTemplateServerBindingExample|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeRegionInstanceTemplate_IP|TestAccComputeRegionInstanceTemplate_IPv6|TestAccComputeRegionInstanceTemplate_basic|TestAccComputeRegionInstanceTemplate_diskIops|TestAccComputeRegionInstanceTemplate_diskResourcePolicies|TestAccComputeRegionInstanceTemplate_enableDisplay|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_instanceResourcePolicies|TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout|TestAccComputeRegionInstanceTemplate_maintenance_interval|TestAccComputeRegionInstanceTemplate_managedEnvoy|TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeRegionInstanceTemplate_networkIP|TestAccComputeRegionInstanceTemplate_networkIPAddress|TestAccComputeRegionInstanceTemplate_networkTier|TestAccComputeRegionInstanceTemplate_preemptible|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccComputeRegionInstanceTemplate_reservationAffinities|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_shieldedVmConfig1|TestAccComputeRegionInstanceTemplate_shieldedVmConfig2|TestAccComputeRegionInstanceTemplate_soleTenantNodeAffinities|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey|TestAccComputeRegionInstanceTemplate_spot|TestAccComputeRegionInstanceTemplate_spot_maxRunDuration|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample|TestAccComputeResourcePolicy_attached|TestAccComputeRoute_hopInstance|TestAccComputeSnapshotIamBindingGenerated|TestAccComputeSnapshotIamMemberGenerated|TestAccComputeSnapshotIamPolicyGenerated|TestAccComputeSnapshot_encryption|TestAccComputeSnapshot_snapshotBasicExample|TestAccComputeSnapshot_snapshotChainnameExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyMtlsExample|TestAccComputeTargetInstance_targetInstanceBasicExample|TestAccComputeTargetInstance_targetInstanceCustomNetworkExample|TestAccComputeTargetInstance_targetInstanceWithSecurityPolicyExample|TestAccComputeTargetInstance_withSecurityPolicy|TestAccComputeTargetPool_basic|TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccContainerAttachedCluster_containerAttachedClusterBasicExample|TestAccContainerAttachedCluster_containerAttachedClusterFullExample|TestAccContainerAttachedCluster_containerAttachedClusterIgnoreErrorsExample|TestAccContainerAttachedCluster_update|TestAccContainerAwsCluster_BasicEnumHandWritten|TestAccContainerAwsCluster_BasicHandWritten|TestAccContainerAwsCluster_BetaBasicEnumHandWritten|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicEnumHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicEnumHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAzureCluster_BasicHandWritten|TestAccContainerAzureCluster_BetaBasicEnumHandWritten|TestAccContainerAzureCluster_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_privateRegistry|TestAccContainerCluster_resourceManagerTags|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withAddons|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerCluster_withAutopilotResourceManagerTags|TestAccContainerCluster_withCostManagementConfig|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withEnableKubernetesBetaAPIs|TestAccContainerCluster_withEnableKubernetesBetaAPIsOnExistingCluster|TestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccContainerCluster_withExternalIpsConfig|TestAccContainerCluster_withFQDNNetworkPolicy|TestAccContainerCluster_withGatewayApiConfig|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerCluster_withMeshCertificatesConfig|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_withNodePoolCIA|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withPrivateEndpointSubnetwork|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withWorkloadALTSConfig|TestAccContainerCluster_withWorkloadALTSConfigAutopilot|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withWorkloadIdentityConfigAutopilot|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerNodePool_ephemeralStorageLocalSsdConfig|TestAccContainerNodePool_localNvmeSsdBlockConfig|TestAccContainerNodePool_resourceManagerTags|TestAccContainerNodePool_version|TestAccContainerNodePool_withCgroupMode|TestAccContainerNodePool_withConfidentialBootDisk|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withReservationAffinity|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withoutConfidentialBootDisk|TestAccDataFusionInstance_dataFusionInstanceCmekExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample|TestAccDataplexTaskDataplexTask_update|TestAccDataplexTaskIamBindingGenerated|TestAccDataplexTaskIamMemberGenerated|TestAccDataplexTaskIamPolicyGenerated|TestAccDataplexTask_dataplexTaskBasicExample|TestAccDataplexTask_dataplexTaskNotebookExample|TestAccDataplexTask_dataplexTaskSparkExample|TestAccDialogflowCXWebhook_update|TestAccEdgecontainerCluster_edgecontainerClusterExample|TestAccEdgecontainerCluster_edgecontainerClusterWithMaintenanceWindowExample|TestAccEssentialContactsContact_essentialContactExample|TestAccEssentialContactsContact_update|TestAccEventarcChannel_basic|TestAccEventarcChannel_cryptoKeyUpdate|TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate|TestAccEventarcTrigger_HttpDest|TestAccEventarcTrigger_channel|TestAccFirestoreDatabase_firestoreCmekDatabaseExample|TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccIntegrationConnectorsConnection|TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update|TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update|TestAccKmsCryptoKeyVersion_externalProtectionLevelOptions|TestAccLoggingBucketConfigBillingAccount_basic|TestAccLoggingBucketConfigOrganization_basic|TestAccLoggingBucketConfigOrganization_indexConfigs|TestAccLoggingOrganizationSettings_update|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccManagedKafkaCluster_managedkafkaClusterBasicExample|TestAccManagedKafkaCluster_managedkafkaClusterCmekExample|TestAccManagedKafkaCluster_update|TestAccManagedKafkaTopic_managedkafkaTopicBasicExample|TestAccManagedKafkaTopic_update|TestAccMemcacheInstance_memcacheInstanceBasicTestExample|TestAccMemcacheInstance_update|TestAccMonitoringSlo_availabilitySli|TestAccMonitoringSlo_basic|TestAccMonitoringSlo_monitoringSloAppengineExample|TestAccMonitoringSlo_windowBasedGoodTotalRatioThresholdSlis|TestAccNetappVolumeReplication_netappVolumeReplicationCreateExample|TestAccNetappVolumeReplication_netappVolumeReplicationCreateExample_update|TestAccNetappVolumeSnapshot_volumeSnapshotCreateExample|TestAccNetappVolumeSnapshot_volumeSnapshotCreateExample_update|TestAccNetappVolume_netappVolumeBasicExample|TestAccNetappVolume_netappVolumeBasicExample_update|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkSecurityGatewaySecurityPolicy_networkSecurityGatewaySecurityPolicyTlsInspectionBasicExample|TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample|TestAccNetworkSecurityTlsInspectionPolicy_networkSecurityTlsInspectionPolicyBasicExample|TestAccNetworkSecurityTlsInspectionPolicy_update|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample|TestAccPubsubLiteSubscription_pubsubLiteSubscriptionBasicExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample|TestAccPubsubSubscriptionBigQuery_update|TestAccPubsubSubscriptionCloudStorage_update|TestAccPubsubSubscription_pubsubSubscriptionPushBqExample|TestAccPubsubSubscription_pubsubSubscriptionPushBqTableSchemaExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample|TestAccPubsubSubscription_push|TestAccPubsubSubscription_pushNoWrapper|TestAccPubsubSubscription_pushNoWrapperEmpty|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstancePrivateServiceTestExample|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecret_cmek|TestAccSecretManagerSecret_rotationPeriodUpdate|TestAccSecretManagerSecret_secretWithAutomaticCmekExample|TestAccSecretManagerSecret_userManagedCmekUpdate|TestAccSecureSourceManagerInstance_secureSourceManagerInstanceCmekExample|TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateExample|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointWithNetworkExample|TestAccSqlDatabaseInstance_encryptionKey|TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample|TestAccStorageInsightsReportConfig_update|TestAccStorageNotification_basic|TestAccStorageNotification_withEventsAndAttributes|TestAccStorageTransferAgentPool_agentPoolUpdate|TestAccStorageTransferJob_basic|TestAccStorageTransferJob_eventStream|TestAccStorageTransferJob_notificationConfig|TestAccStorageTransferJob_objectConditions|TestAccStorageTransferJob_omitScheduleEndDate|TestAccStorageTransferJob_posixSink|TestAccStorageTransferJob_posixSource|TestAccStorageTransferJob_transferJobName|TestAccStorageTransferJob_transferOptions|TestAccTPUNode_tpuNodeBUpdateTensorFlowVersion|TestAccTPUNode_tpuNodeBasicExample|TestAccTPUNode_tpuNodeFullTestExample|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIEndpointIamBinding|TestAccVertexAIEndpointIamMember|TestAccVertexAIEndpointIamPolicy|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewWithVectorSearchExample|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsBigtableExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointTestExample|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPscExample|TestAccVertexAITensorboard_vertexAiTensorboardFullExample|TestAccWorkstationsWorkstationCluster_Private_update|TestAccWorkstationsWorkstationCluster_update|TestAccWorkstationsWorkstationCluster_workstationClusterBasicExample|TestAccWorkstationsWorkstationCluster_workstationClusterCustomDomainExample|TestAccWorkstationsWorkstationCluster_workstationClusterPrivateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 462 insertions(+))
google-beta provider: Diff ( 18 files changed, 2755 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 459 insertions(+))
google-beta provider: Diff ( 18 files changed, 2731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3724
Passed tests: 3143
Skipped tests: 373
Affected tests: 208

Click here to see the affected service packages
all service packages are affected

Action taken

Found 208 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccApigeeSyncAuthorization_update|TestAccBinaryAuthorizationAttestor_kms|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample|TestAccCloudAssetProjectFeed_cloudAssetProjectFeedExample|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_webhook_config|TestAccCloudFunctionsFunction_dockerRepository|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudIdsEndpoint_basic|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccCloudSchedulerJob_schedulerJobOauthExample|TestAccCloudSchedulerJob_schedulerJobOidcExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccComposer1Environment_withNodeConfig|TestAccComposer2Environment_withNodeConfig|TestAccComposerEnvironment_fixPyPiPackages|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeInstance_guestAccelerator|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeTargetPool_basic|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_resourceManagerTags|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withAddons|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withAutopilotResourceManagerTags|TestAccContainerCluster_withFQDNNetworkPolicy|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerCluster_withNodePoolCIA|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withWorkloadALTSConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerNodePool_resourceManagerTags|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccDataFusionInstance_dataFusionInstanceCmekExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample|TestAccDataplexTaskDataplexTask_update|TestAccDataplexTaskIamBindingGenerated|TestAccDataplexTaskIamMemberGenerated|TestAccDataplexTaskIamPolicyGenerated|TestAccDataplexTask_dataplexTaskBasicExample|TestAccDataplexTask_dataplexTaskNotebookExample|TestAccDataplexTask_dataplexTaskSparkExample|TestAccDialogflowCXWebhook_update|TestAccEdgecontainerCluster_edgecontainerClusterExample|TestAccEdgecontainerCluster_edgecontainerClusterWithMaintenanceWindowExample|TestAccEssentialContactsContact_essentialContactExample|TestAccEssentialContactsContact_update|TestAccEventarcChannel_basic|TestAccEventarcChannel_cryptoKeyUpdate|TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate|TestAccEventarcTrigger_HttpDest|TestAccEventarcTrigger_channel|TestAccFirestoreDatabase_firestoreCmekDatabaseExample|TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccIntegrationConnectorsConnection|TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update|TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update|TestAccKmsCryptoKeyVersion_externalProtectionLevelOptions|TestAccLoggingBucketConfigBillingAccount_basic|TestAccLoggingBucketConfigOrganization_basic|TestAccLoggingBucketConfigOrganization_indexConfigs|TestAccLoggingOrganizationSettings_update|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccManagedKafkaCluster_managedkafkaClusterBasicExample|TestAccManagedKafkaCluster_managedkafkaClusterCmekExample|TestAccManagedKafkaCluster_update|TestAccManagedKafkaTopic_managedkafkaTopicBasicExample|TestAccManagedKafkaTopic_update|TestAccMemcacheInstance_memcacheInstanceBasicTestExample|TestAccMemcacheInstance_update|TestAccMonitoringSlo_availabilitySli|TestAccMonitoringSlo_basic|TestAccMonitoringSlo_monitoringSloAppengineExample|TestAccMonitoringSlo_windowBasedGoodTotalRatioThresholdSlis|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkSecurityGatewaySecurityPolicy_networkSecurityGatewaySecurityPolicyTlsInspectionBasicExample|TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample|TestAccNetworkSecurityTlsInspectionPolicy_networkSecurityTlsInspectionPolicyBasicExample|TestAccNetworkSecurityTlsInspectionPolicy_update|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample|TestAccPubsubLiteSubscription_pubsubLiteSubscriptionBasicExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample|TestAccPubsubSubscriptionBigQuery_update|TestAccPubsubSubscriptionCloudStorage_update|TestAccPubsubSubscription_pubsubSubscriptionPushBqExample|TestAccPubsubSubscription_pubsubSubscriptionPushBqTableSchemaExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample|TestAccPubsubSubscription_push|TestAccPubsubSubscription_pushNoWrapper|TestAccPubsubSubscription_pushNoWrapperEmpty|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstancePrivateServiceTestExample|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecret_cmek|TestAccSecretManagerSecret_rotationPeriodUpdate|TestAccSecretManagerSecret_secretWithAutomaticCmekExample|TestAccSecretManagerSecret_userManagedCmekUpdate|TestAccSecureSourceManagerInstance_secureSourceManagerInstanceCmekExample|TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateExample|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointWithNetworkExample|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample|TestAccStorageInsightsReportConfig_update|TestAccStorageNotification_basic|TestAccStorageNotification_withEventsAndAttributes|TestAccStorageTransferAgentPool_agentPoolUpdate|TestAccStorageTransferJob_basic|TestAccStorageTransferJob_eventStream|TestAccStorageTransferJob_notificationConfig|TestAccStorageTransferJob_objectConditions|TestAccStorageTransferJob_omitScheduleEndDate|TestAccStorageTransferJob_posixSink|TestAccStorageTransferJob_posixSource|TestAccStorageTransferJob_transferJobName|TestAccStorageTransferJob_transferOptions|TestAccTPUNode_tpuNodeBUpdateTensorFlowVersion|TestAccTPUNode_tpuNodeBasicExample|TestAccTPUNode_tpuNodeFullTestExample|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIEndpointIamBinding|TestAccVertexAIEndpointIamMember|TestAccVertexAIEndpointIamPolicy|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewWithVectorSearchExample|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsBigtableExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointTestExample|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPscExample|TestAccVertexAITensorboard_vertexAiTensorboardFullExample|TestAccWorkstationsWorkstationCluster_Private_update|TestAccWorkstationsWorkstationCluster_update|TestAccWorkstationsWorkstationCluster_workstationClusterBasicExample|TestAccWorkstationsWorkstationCluster_workstationClusterCustomDomainExample|TestAccWorkstationsWorkstationCluster_workstationClusterPrivateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3729
Passed tests: 3148
Skipped tests: 373
Affected tests: 208

Click here to see the affected service packages
all service packages are affected

Action taken

Found 208 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccApigeeSyncAuthorization_update|TestAccBinaryAuthorizationAttestor_kms|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample|TestAccCloudAssetProjectFeed_cloudAssetProjectFeedExample|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_webhook_config|TestAccCloudFunctionsFunction_dockerRepository|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudIdsEndpoint_basic|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccCloudSchedulerJob_schedulerJobOauthExample|TestAccCloudSchedulerJob_schedulerJobOidcExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccComposer1Environment_withNodeConfig|TestAccComposer2Environment_withNodeConfig|TestAccComposerEnvironment_fixPyPiPackages|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeInstance_guestAccelerator|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeTargetPool_basic|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_resourceManagerTags|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withAddons|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withAutopilotResourceManagerTags|TestAccContainerCluster_withFQDNNetworkPolicy|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerCluster_withNodePoolCIA|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withWorkloadALTSConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerNodePool_resourceManagerTags|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccDataFusionInstance_dataFusionInstanceCmekExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample|TestAccDataplexTaskDataplexTask_update|TestAccDataplexTaskIamBindingGenerated|TestAccDataplexTaskIamMemberGenerated|TestAccDataplexTaskIamPolicyGenerated|TestAccDataplexTask_dataplexTaskBasicExample|TestAccDataplexTask_dataplexTaskNotebookExample|TestAccDataplexTask_dataplexTaskSparkExample|TestAccDialogflowCXWebhook_update|TestAccEdgecontainerCluster_edgecontainerClusterExample|TestAccEdgecontainerCluster_edgecontainerClusterWithMaintenanceWindowExample|TestAccEssentialContactsContact_essentialContactExample|TestAccEssentialContactsContact_update|TestAccEventarcChannel_basic|TestAccEventarcChannel_cryptoKeyUpdate|TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate|TestAccEventarcTrigger_HttpDest|TestAccEventarcTrigger_channel|TestAccFirestoreDatabase_firestoreCmekDatabaseExample|TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccIntegrationConnectorsConnection|TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update|TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update|TestAccKmsCryptoKeyVersion_externalProtectionLevelOptions|TestAccLoggingBucketConfigBillingAccount_basic|TestAccLoggingBucketConfigOrganization_basic|TestAccLoggingBucketConfigOrganization_indexConfigs|TestAccLoggingOrganizationSettings_update|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccManagedKafkaCluster_managedkafkaClusterBasicExample|TestAccManagedKafkaCluster_managedkafkaClusterCmekExample|TestAccManagedKafkaCluster_update|TestAccManagedKafkaTopic_managedkafkaTopicBasicExample|TestAccManagedKafkaTopic_update|TestAccMemcacheInstance_memcacheInstanceBasicTestExample|TestAccMemcacheInstance_update|TestAccMonitoringSlo_availabilitySli|TestAccMonitoringSlo_basic|TestAccMonitoringSlo_monitoringSloAppengineExample|TestAccMonitoringSlo_windowBasedGoodTotalRatioThresholdSlis|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkSecurityGatewaySecurityPolicy_networkSecurityGatewaySecurityPolicyTlsInspectionBasicExample|TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample|TestAccNetworkSecurityTlsInspectionPolicy_networkSecurityTlsInspectionPolicyBasicExample|TestAccNetworkSecurityTlsInspectionPolicy_update|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample|TestAccPubsubLiteSubscription_pubsubLiteSubscriptionBasicExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample|TestAccPubsubSubscriptionBigQuery_update|TestAccPubsubSubscriptionCloudStorage_update|TestAccPubsubSubscription_pubsubSubscriptionPushBqExample|TestAccPubsubSubscription_pubsubSubscriptionPushBqTableSchemaExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample|TestAccPubsubSubscription_push|TestAccPubsubSubscription_pushNoWrapper|TestAccPubsubSubscription_pushNoWrapperEmpty|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstancePrivateServiceTestExample|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecret_cmek|TestAccSecretManagerSecret_rotationPeriodUpdate|TestAccSecretManagerSecret_secretWithAutomaticCmekExample|TestAccSecretManagerSecret_userManagedCmekUpdate|TestAccSecureSourceManagerInstance_secureSourceManagerInstanceCmekExample|TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateExample|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointWithNetworkExample|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample|TestAccStorageInsightsReportConfig_update|TestAccStorageNotification_basic|TestAccStorageNotification_withEventsAndAttributes|TestAccStorageTransferAgentPool_agentPoolUpdate|TestAccStorageTransferJob_basic|TestAccStorageTransferJob_eventStream|TestAccStorageTransferJob_notificationConfig|TestAccStorageTransferJob_objectConditions|TestAccStorageTransferJob_omitScheduleEndDate|TestAccStorageTransferJob_posixSink|TestAccStorageTransferJob_posixSource|TestAccStorageTransferJob_transferJobName|TestAccStorageTransferJob_transferOptions|TestAccTPUNode_tpuNodeBUpdateTensorFlowVersion|TestAccTPUNode_tpuNodeBasicExample|TestAccTPUNode_tpuNodeFullTestExample|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIEndpointIamBinding|TestAccVertexAIEndpointIamMember|TestAccVertexAIEndpointIamPolicy|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewWithVectorSearchExample|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsBigtableExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointTestExample|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPscExample|TestAccVertexAITensorboard_vertexAiTensorboardFullExample|TestAccWorkstationsWorkstationCluster_Private_update|TestAccWorkstationsWorkstationCluster_update|TestAccWorkstationsWorkstationCluster_workstationClusterBasicExample|TestAccWorkstationsWorkstationCluster_workstationClusterCustomDomainExample|TestAccWorkstationsWorkstationCluster_workstationClusterPrivateExample

Get to know how VCR tests work

@jessdejong
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 459 insertions(+))
google-beta provider: Diff ( 18 files changed, 2731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3740
Passed tests: 3331
Skipped tests: 376
Affected tests: 33

Click here to see the affected service packages
all service packages are affected

Action taken

Found 33 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_webhook_config|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_secretMount|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_versions|TestAccIntegrationConnectorsConnection|TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccManagedKafkaCluster_managedkafkaClusterBasicExample|TestAccManagedKafkaCluster_managedkafkaClusterCmekExample|TestAccManagedKafkaCluster_update|TestAccManagedKafkaTopic_managedkafkaTopicBasicExample|TestAccManagedKafkaTopic_update|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_versions|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample[Debug log]
TestAccCloudBuildTrigger_webhook_config[Debug log]
TestAccCloudFunctionsFunction_secretEnvVar[Debug log]
TestAccCloudFunctionsFunction_secretMount[Debug log]
TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample[Debug log]
TestAccCloudRunService_cloudRunServiceSecretVolumesExample[Debug log]
TestAccCloudRunService_secretEnvironmentVariable[Debug log]
TestAccCloudRunService_secretVolume[Debug log]
TestAccComputeBackendService_withBackendAndIAP[Debug log]
TestAccComputePerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputePerInstanceConfig_statefulIps[Debug log]
TestAccComputePerInstanceConfig_update[Debug log]
TestAccInstanceGroupManager_targetSizeZero[Debug log]
TestAccInstanceGroupManager_versions[Debug log]
TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update[Debug log]
TestAccManagedKafkaCluster_update[Debug log]
TestAccManagedKafkaTopic_managedkafkaTopicBasicExample[Debug log]
TestAccManagedKafkaTopic_update[Debug log]
TestAccRegionInstanceGroupManager_distributionPolicy[Debug log]
TestAccRegionInstanceGroupManager_resourceManagerTags[Debug log]
TestAccRegionInstanceGroupManager_stateful[Debug log]
TestAccRegionInstanceGroupManager_targetSizeZero[Debug log]
TestAccRegionInstanceGroupManager_versions[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]
TestAccIntegrationConnectorsConnection[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccManagedKafkaCluster_managedkafkaClusterBasicExample[Error message] [Debug log]
TestAccManagedKafkaCluster_managedkafkaClusterCmekExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@jessdejong jessdejong marked this pull request as ready for review June 5, 2024 16:45
@github-actions github-actions bot requested a review from slevenick June 5, 2024 16:46
Copy link

github-actions bot commented Jun 5, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@jessdejong
Copy link
Member Author

@slevenick will be reviewing

@jessdejong
Copy link
Member Author

/gcbrun to see if more tests will pass

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 459 insertions(+))
google-beta provider: Diff ( 18 files changed, 2731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3756
Passed tests: 3348
Skipped tests: 378
Affected tests: 30

Click here to see the affected service packages
all service packages are affected

Action taken

Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_versions|TestAccIntegrationConnectorsConnection|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccManagedKafkaCluster_managedkafkaClusterBasicExample|TestAccManagedKafkaCluster_managedkafkaClusterCmekExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_versions|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccComputeBackendService_withBackendAndIAP[Debug log]
TestAccComputeInstanceGroup_rename[Debug log]
TestAccComputeInstanceTemplate_sourceImageEncryptionKey[Debug log]
TestAccComputePerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputePerInstanceConfig_statefulIps[Debug log]
TestAccComputePerInstanceConfig_update[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccInstanceGroupManager_targetSizeZero[Debug log]
TestAccInstanceGroupManager_versions[Debug log]
TestAccIntegrationConnectorsConnection[Debug log]
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample[Debug log]
TestAccNetworkManagementConnectivityTest_update[Debug log]
TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample[Debug log]
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample[Debug log]
TestAccRegionInstanceGroupManager_distributionPolicy[Debug log]
TestAccRegionInstanceGroupManager_resourceManagerTags[Debug log]
TestAccRegionInstanceGroupManager_stateful[Debug log]
TestAccRegionInstanceGroupManager_targetSizeZero[Debug log]
TestAccRegionInstanceGroupManager_versions[Debug log]
TestAccTags[Debug log]
TestAccTagsLocationTagBinding_locationTagBindingzonal[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccManagedKafkaCluster_managedkafkaClusterBasicExample[Error message] [Debug log]
TestAccManagedKafkaCluster_managedkafkaClusterCmekExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@jessdejong
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 466 insertions(+))
google-beta provider: Diff ( 18 files changed, 2748 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 466 insertions(+))
google-beta provider: Diff ( 18 files changed, 2748 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3756
Passed tests: 3370
Skipped tests: 378
Affected tests: 8

Click here to see the affected service packages
all service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccManagedKafkaCluster_managedkafkaClusterBasicExample|TestAccManagedKafkaCluster_managedkafkaClusterCmekExample|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3756
Passed tests: 3370
Skipped tests: 378
Affected tests: 8

Click here to see the affected service packages
all service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccManagedKafkaCluster_managedkafkaClusterBasicExample|TestAccManagedKafkaCluster_managedkafkaClusterCmekExample|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccManagedKafkaCluster_managedkafkaClusterBasicExample[Debug log]
TestAccManagedKafkaCluster_managedkafkaClusterCmekExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccManagedKafkaCluster_managedkafkaClusterBasicExample[Debug log]
TestAccManagedKafkaCluster_managedkafkaClusterCmekExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 456 insertions(+))
google-beta provider: Diff ( 18 files changed, 2728 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 322 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3757
Passed tests: 3372
Skipped tests: 379
Affected tests: 6

Click here to see the affected service packages
all service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

@jessdejong jessdejong reopened this Jun 10, 2024
@jessdejong
Copy link
Member Author

Accidentally reset this PR but now everything should be good! And I added the copyright notice and rebased.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 163 insertions(+))
google-beta provider: Diff ( 6 files changed, 1010 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

2 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 163 insertions(+))
google-beta provider: Diff ( 6 files changed, 1010 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 163 insertions(+))
google-beta provider: Diff ( 6 files changed, 1010 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • managedkafka

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 163 insertions(+))
google-beta provider: Diff ( 6 files changed, 1010 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • managedkafka

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • managedkafka

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • managedkafka

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 164 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1011 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • managedkafka

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 164 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1011 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • managedkafka

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks reasonable, I have a couple comments about the tests

@github-actions github-actions bot requested a review from slevenick June 10, 2024 19:30
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 164 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1011 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • managedkafka

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants