Fix content in the google_storage_bucket_object_content data source which is incorrectly marked as a non-computed attribute

[wafrelka]

Fixes hashicorp/terraform-provider-google#15717

Release Note Template for Downstream PRs (will be copied)

storage: fixed an issue where plans with a dependency on the `content` field in the `google_storage_bucket_object_content` data source could erroneously fail

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 28 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 28 insertions(+), 3 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field content transitioned from optional+computed to optional google_storage_bucket_object - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 95
Passed tests: 88
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages

• storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceStorageBucketObjectContent_Issue15717

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceStorageBucketObjectContent_Issue15717[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[github-actions]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

Going to verify some of the behavior here locally to ensure this change isn't actually breaking due to the weirdness of how GCS buckets function as handwritten resources.

[github-actions]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[wafrelka]

Is there anything I should do to move this Pull Request forward?

[NickElliot]

Sorry about that prolonged check on my end.

Can you undo the change removing the "computed" attribute from the resource? I don't believe it should affect the change made in mmv1/third_party/terraform/services/storage/data_source_storage_bucket_object_content.go that would resolve the null issue, and would prevent this from being a breaking change.

[wafrelka]

I don't think this is a breaking change as content has never been a computed attribute since it was implemented.

Nevertheless, I reverted the change to the resource and force-pushed the branch.
Thank you for your review. :)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 28 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 28 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 97
Passed tests: 90
Skipped tests: 7
Affected tests: 0

Click here to see the affected service packages

• storage

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[wafrelka]

Could you take a look?

[NickElliot]

LGTM!

[NickElliot]

@wafrelka this change is going to be reverted because removing the ability to supply to the data source is breaking (despite this not having functional purpose), if you want to reopen the PR against the 6.0.0 release branch (per https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/) that would be appreciated!

I'll go ahead and handle adding the deprecation notice in the meantime.

[wafrelka]

@NickElliot can we mark the content attribute as "computed" and "optional"?
I think it will fix hashicorp/terraform-provider-google#15717 without breaking the ability to set the field.