Add beta support for custom error response policies for URL maps

[daanheikens]

Fixes: hashicorp/terraform-provider-google#18200

Release Note Template for Downstream PRs (will be copied)

compute: added fields `customErrorResponsePolicy` and `defaultErrorResponsePolicy` to the `google_compute_url_map` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[daanheikens]

Hey @rileykarson, bumping up this one.

One of my colleagues requested this one and it would really help us to enhance a solution we are designing.

[rileykarson]

Started generation, probably won't be done before I sign off for the day. Will try to get a full pass done Monday, sorry for the delay!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 477 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1284 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 254 insertions(+))

[modular-magician]

Tests analytics

Total tests: 942
Passed tests: 866
Skipped tests: 72
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputeUrlMap_urlMapCustomErrorResponsePolicyExample|TestAccComputeUrlMap_urlMapCustomErrorResponsePolicyUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeUrlMap_urlMapCustomErrorResponsePolicyExample[Debug log]
TestAccComputeUrlMap_urlMapCustomErrorResponsePolicyUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[daanheikens]

Started generation, probably won't be done before I sign off for the day. Will try to get a full pass done Monday, sorry for the delay!

No worries! Thanks. I will process your feedback.

[github-actions]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[nika-pr]

Does someone else have time to review this? We are waiting for this to get merged...

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 257 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1284 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 254 insertions(+))

[modular-magician]

Tests analytics

Total tests: 958
Passed tests: 883
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

Should the subvalues here be required, or can they be omitted? If they can be omitted, can we do that in some of the tests?

[daanheikens]

I will have a look which are required and which are not.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 257 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1284 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 254 insertions(+))

[modular-magician]

Tests analytics

Total tests: 962
Passed tests: 887
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

(TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy is probably unrelated and you can ignore it unless I flag it specifically)

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

LGTM, thanks!