Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource SCC Management Organization Security Health Analytics Custom Module #10815

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

vijaykanthm
Copy link
Contributor

@vijaykanthm vijaykanthm commented May 28, 2024

Related to http://b/330538229.
Issue No: https://b.corp.google.com/issues/339718455

Requirement Doc: https://docs.google.com/document/d/1b97vduAO9BPiTTFa-muB9c9ACuDFlAOZW745PrkohXM/edit?tab=t.0#heading=h.cujlsysi3w59

Adding new template to move from SCC API v1 → SCC Management API for post-V2-GA release customers and to support
https://cloud.google.com/security-command-center/docs/reference/security-center-management/rest/v1/organizations.locations.securityHealthAnalyticsCustomModules

Release Note Template for Downstream PRs (will be copied)

`google_scc_management_organization_security_health_analytics_custom_module`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from slevenick May 28, 2024 21:36
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 28, 2024
@vijaykanthm vijaykanthm changed the title Scc mgmt org sha Add Resource SSC Management Organization Security Health Analytics Custom Module May 28, 2024
@vijaykanthm vijaykanthm changed the title Add Resource SSC Management Organization Security Health Analytics Custom Module Add Resource SCC Management Organization Security Health Analytics Custom Module May 28, 2024
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting and several other steps are failing

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 29, 2024
@github-actions github-actions bot requested a review from slevenick May 29, 2024 20:41
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 29, 2024
Copy link

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/securitycenter and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 31, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2319 insertions(+), 648 deletions(-))
google-beta provider: Diff ( 11 files changed, 2415 insertions(+), 754 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 338 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting on the test is causing failures, please run make fmt to correct it

@github-actions github-actions bot requested a review from slevenick June 3, 2024 06:00
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2319 insertions(+), 648 deletions(-))
google-beta provider: Diff ( 11 files changed, 2415 insertions(+), 754 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 338 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@slevenick
Copy link
Contributor

/gcbrun

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2319 insertions(+), 648 deletions(-))
google-beta provider: Diff ( 11 files changed, 2415 insertions(+), 754 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 338 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the package names issues:
found packages securitycentermanagement (resource_scc_management_organization_security_health_analytics_custom_module.go) and securitycenter (resource_scc_management_organization_security_health_analytics_custom_module_test.go)

@github-actions github-actions bot requested a review from slevenick June 3, 2024 18:00
Copy link

github-actions bot commented Jun 5, 2024

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 5, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2278 insertions(+), 651 deletions(-))
google-beta provider: Diff ( 5 files changed, 2385 insertions(+), 758 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests: 1
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycentermanagement

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSecurityCenterManagementOrganizationSecurityHealthAnalyticsCustomModule

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterManagementOrganizationSecurityHealthAnalyticsCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 5, 2024
@vijaykanthm
Copy link
Contributor Author

Hi @slevenick, can you please have a look at the PR, I have addressed the comments and made some changes, can you approve the step to trigger the next steps in the CI. Thanks.

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 7, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2278 insertions(+), 651 deletions(-))
google-beta provider: Diff ( 5 files changed, 2385 insertions(+), 758 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests: 1
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycentermanagement

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSecurityCenterManagementOrganizationSecurityHealthAnalyticsCustomModule

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterManagementOrganizationSecurityHealthAnalyticsCustomModule[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

characters or underscores only.
- !ruby/object:Api::Type::Enum
name: 'enablementState'
required: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required: false is the default value, so these can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@github-actions github-actions bot requested a review from slevenick June 7, 2024 17:50
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 7, 2024
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2281 insertions(+), 654 deletions(-))
google-beta provider: Diff ( 5 files changed, 2389 insertions(+), 762 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycentermanagement

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants