Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private environment config to composer #1999

Merged
merged 5 commits into from
Jul 17, 2019
Merged

Add private environment config to composer #1999

merged 5 commits into from
Jul 17, 2019

Conversation

tysen
Copy link

@tysen tysen commented Jul 2, 2019 •
edited by emilymye

Release Note for Downstream PRs (will be copied)

composer: Add private IP config for `google_composer_environment`

@tysen tysen requested a review from emilymye July 2, 2019 00:02
@tysen
Copy link
Author

tysen commented Jul 2, 2019

I need to update this with docs - I'll do that tomorrow. Also, what format should the release note be in?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of fd54bb1.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#908
depends: hashicorp/terraform-provider-google#3952
depends: modular-magician/ansible#296

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ece2def.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@emilymye
Copy link
Contributor

emilymye commented Jul 9, 2019 •
edited

@tysen sorry, just saw this! rebase on 2003 for release note to work properly :/ I went ahead and edited the release note - it should just be the release note you'd put without a bullet.

emilymye
emilymye reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@emilymye emilymye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidently left my comments on TPG PR

third_party/terraform/tests/resource_composer_environment_test.go.erb Outdated Show resolved Hide resolved
third_party/terraform/tests/resource_composer_environment_test.go.erb
@@ -285,6 +319,27 @@ resource "google_composer_environment" "test" {
`, name)
}

func testAccComposerEnvironment_private(name string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there an issue with testing the other fields (like range overlap)? Would be a good idea to test actually setting the other fields for cidr ranges if we can

@tysen tysen mentioned this pull request Jul 15, 2019
Closed
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b612cb9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye
emilymye approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@emilymye emilymye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boolean for use_ip_aliases is more of a style thing than a functionality thing - since container's use_ip_aliases defaults to true, I'd probably prefer also doing that. Otherwise, just a small typo and LGTM

third_party/terraform/website/docs/r/composer_environment.html.markdown Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4ac0fe6.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician merged commit 914809b into GoogleCloudPlatform:master Jul 17, 2019
@tysen tysen deleted the private-composer branch July 17, 2019 20:53
This was referenced Jul 18, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 19, 2019
Merged
Merged
Merged
@tysen tysen mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilymye emilymye emilymye approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
4 participants
@tysen @modular-magician @emilymye @googlebot