Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML Engine: Versions on Ansible #2068

Merged
merged 6 commits into from
Jul 17, 2019
Merged

ML Engine: Versions on Ansible #2068

merged 6 commits into from
Jul 17, 2019

Conversation

rambleraptor
Copy link
Contributor

https://github.com/GoogleCloudPlatform/magic-modules/issues/2061

Versions on Ansible! This also has a couple Model fixes:

  • Async on Model Deletes (because just deletes are async on Models)
  • A better decoder that doesn't break on Operations.

Release Note for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

modular-magician commented Jul 17, 2019

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 7e41ccb5c82d3bcc196947598317018f16dee584.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#315

products/mlengine/api.yaml Show resolved Hide resolved
- !ruby/object:Api::Type::Integer
name: 'minNodes'
description: The minimum number of nodes to allocate for this mode
- !ruby/object:Api::Type::NestedObject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to flatten the scaling-related nested objects' single member fields into top-level params?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ansible doesn't have this feature currently (I believe TF does).

@rambleraptor
Copy link
Contributor Author

I also added the support to set a default version (uses a custom endpoint).

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5920954.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0e30d1d.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3decb1e.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants