Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer access control #3503

Merged

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented May 13, 2020

Fixes: hashicorp/terraform-provider-google#6106

Release Note Template for Downstream PRs (will be copied)

composer: Added support for `google_composer_environment` `web_server_network_access_control` for private environments (Beta only)
composer: Added support for `google_composer_environment` `config.private_environment_config.cloud_sql_ipv4_cidr_block`
composer: Added support for `google_composer_environment` `config.private_environment_config.web_server_ipv4_cidr_block`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 91 insertions(+))
Terraform Beta: Diff ( 3 files changed, 316 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 78 insertions(+))
Terraform Beta: Diff ( 3 files changed, 316 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 79 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 317 insertions(+), 1 deletion(-))

@slevenick slevenick requested a review from emilymye May 13, 2020 17:58
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 88 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 321 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 81 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 320 insertions(+), 1 deletion(-))

Copy link
Contributor

@emilymye emilymye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might add version gates around the at_least_one_of's - it doesn't seem to be actually causing issues when TF runs, but might print confusing error messages in GA. Otherwise LGTM

@slevenick
Copy link
Contributor Author

I might add version gates around the at_least_one_of's - it doesn't seem to be actually causing issues when TF runs, but might print confusing error messages in GA. Otherwise LGTM

All the fields in that block are GA, only the allowed_ip_range is beta

@slevenick slevenick merged commit 11b8d2f into GoogleCloudPlatform:master May 15, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
* Create works, update needs help

* non-plural name for set items

* Add sql and web server ip cidr blocks

* Test passes

* Remove schema from ga version, fix lint erro

* Add note to composer docs linking to private environment setup

* Computed web server access as it has default values set by API. Ignore during import tests

* Add computed to new cidr blocks as they get default values based on the region they exist in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants