Add memcache instance. #3593

nat-henderson · 2020-06-02T19:26:24Z

Release Note Template for Downstream PRs (will be copied)

`google_memcache_instance`

modular-magician · 2020-06-02T19:33:18Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1144 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1144 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 191 insertions(+))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2020-06-03T00:16:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1144 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1144 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 191 insertions(+))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

modular-magician · 2020-06-03T21:24:31Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 84 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1142 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

modular-magician · 2020-06-03T21:41:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 84 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1142 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

modular-magician · 2020-06-03T22:14:40Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 1142 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

modular-magician · 2020-06-03T22:16:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 1180 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

modular-magician · 2020-06-03T22:35:34Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 1186 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-03T23:14:48Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 1186 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-03T23:43:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 1188 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-04T00:05:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 1188 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

slevenick · 2020-06-04T17:54:55Z

products/memcache/api.yaml

+          - !ruby/object:Api::Type::Integer
+            name: memorySizeMb
+            description: |
+              Memory size in Mibibytes for each memcache node.


"Mibibytes"?

Yep - MiB.

https://en.wikipedia.org/wiki/Mebibyte

Oh I guess it's "mebibytes" - typo'd it.

products/memcache/api.yaml

products/memcache/terraform.yaml

products/memcache/api.yaml

Co-authored-by: Sam Levenick <slevenick@google.com>

modular-magician · 2020-06-04T19:36:43Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 8 files changed, 1188 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-04T19:50:11Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 115 insertions(+))
Terraform Beta: Diff ( 9 files changed, 1303 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-04T20:00:25Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 9 files changed, 1303 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-04T20:15:54Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 9 files changed, 1303 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-04T20:35:08Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 9 files changed, 1295 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-04T21:48:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 9 files changed, 1242 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-04T22:24:19Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 9 files changed, 1251 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-04T22:24:27Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118018"

nat-henderson · 2020-06-04T22:47:54Z

Awesome - tests pass now. @slevenick PTAL when you are ready.

slevenick · 2020-06-05T15:54:54Z

products/memcache/terraform.yaml

+        custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.erb'
+      displayName: !ruby/object:Overrides::Terraform::PropertyOverride
+        default_from_api: true
+      zones: !ruby/object:Overrides::Terraform::PropertyOverride


Should this be a set instead of an array?

Probably - done!

modular-magician · 2020-06-05T19:47:56Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 9 files changed, 1265 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 134 insertions(+))

modular-magician · 2020-06-05T19:48:02Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=118266"

googlebot added the cla: yes label Jun 2, 2020

nat-henderson force-pushed the memorystore branch from c27e3de to f93648d Compare June 3, 2020 00:09

Initial commit of memcache instance.

2aec22e

nat-henderson force-pushed the memorystore branch from 9efe32a to 75f9f3b Compare June 3, 2020 21:12

move to beta.

8c08ea2

nat-henderson force-pushed the memorystore branch from 75f9f3b to 8c08ea2 Compare June 3, 2020 21:17

Increase memory per node to the minimum.

11fcc77

nat-henderson added 2 commits June 3, 2020 15:08

Remove empty GA version to eliminate lint errors.

30cd371

enable private service networking.

aa17dfc

No non-beta provider available.

ab3abe7

reorder service networking enablement.

59b095a

optional/computed for a few fields that might get set server-side.

d8cf55f

significantly increase timeouts.

88882f4

nat-henderson requested a review from slevenick June 4, 2020 07:04

slevenick reviewed Jun 4, 2020

View reviewed changes

Apply suggestions from code review

46888ac

Co-authored-by: Sam Levenick <slevenick@google.com>

Add additional testing.

d8474eb

Make sure test only runs in beta.

87f6da5

randInt, not RandInt.

5840823

Do we not need to say beta here?

2f19a2f

most fields cannot be updated.

dd2b235

node count should be patchable.

0d14be3

slevenick approved these changes Jun 5, 2020

View reviewed changes

labels are updateable, and zones are a set.

e3f0910

nat-henderson merged commit c58b346 into GoogleCloudPlatform:master Jun 5, 2020

This was referenced Jun 5, 2020

Add memcache instance. hashicorp/terraform-provider-google#6540

Merged

Add memcache instance. hashicorp/terraform-provider-google-beta#2142

Merged

nat-henderson mentioned this pull request Jun 8, 2020

Cloud Memorystore for Memcached hashicorp/terraform-provider-google#6202

Closed

ermakov-oleg mentioned this pull request Jul 8, 2020

Impossible specify memcache_parameters for google_memcache_instance hashicorp/terraform-provider-google#6759

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add memcache instance. #3593

Add memcache instance. #3593

nat-henderson commented Jun 2, 2020

modular-magician commented Jun 2, 2020

modular-magician commented Jun 3, 2020

modular-magician commented Jun 3, 2020

modular-magician commented Jun 3, 2020

modular-magician commented Jun 3, 2020

modular-magician commented Jun 3, 2020

modular-magician commented Jun 3, 2020

modular-magician commented Jun 3, 2020

modular-magician commented Jun 3, 2020

modular-magician commented Jun 4, 2020

slevenick Jun 4, 2020

nat-henderson Jun 4, 2020

nat-henderson Jun 4, 2020

modular-magician commented Jun 4, 2020

modular-magician commented Jun 4, 2020

modular-magician commented Jun 4, 2020

modular-magician commented Jun 4, 2020

modular-magician commented Jun 4, 2020

modular-magician commented Jun 4, 2020

modular-magician commented Jun 4, 2020

modular-magician commented Jun 4, 2020

nat-henderson commented Jun 4, 2020

slevenick Jun 5, 2020

nat-henderson Jun 5, 2020

modular-magician commented Jun 5, 2020

modular-magician commented Jun 5, 2020

Add memcache instance. #3593

Add memcache instance. #3593

Conversation

nat-henderson commented Jun 2, 2020

modular-magician commented Jun 2, 2020

Diff report:

modular-magician commented Jun 3, 2020

Diff report:

modular-magician commented Jun 3, 2020

Diff report:

modular-magician commented Jun 3, 2020

Diff report:

modular-magician commented Jun 3, 2020

Diff report:

modular-magician commented Jun 3, 2020

Diff report:

modular-magician commented Jun 3, 2020

Diff report:

modular-magician commented Jun 3, 2020

Diff report:

modular-magician commented Jun 3, 2020

Diff report:

modular-magician commented Jun 4, 2020

Diff report:

slevenick Jun 4, 2020

Choose a reason for hiding this comment

nat-henderson Jun 4, 2020

Choose a reason for hiding this comment

nat-henderson Jun 4, 2020

Choose a reason for hiding this comment

modular-magician commented Jun 4, 2020

Diff report:

modular-magician commented Jun 4, 2020

Diff report:

modular-magician commented Jun 4, 2020

Diff report:

modular-magician commented Jun 4, 2020

Diff report:

modular-magician commented Jun 4, 2020

Diff report:

modular-magician commented Jun 4, 2020

Diff report:

modular-magician commented Jun 4, 2020

Diff report:

modular-magician commented Jun 4, 2020

nat-henderson commented Jun 4, 2020

slevenick Jun 5, 2020

Choose a reason for hiding this comment

nat-henderson Jun 5, 2020

Choose a reason for hiding this comment

modular-magician commented Jun 5, 2020

Diff report:

modular-magician commented Jun 5, 2020