Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add examples for L7-XLB Header & Parameter Based Routing #3703

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Jun 24, 2020

Fixes hashicorp/terraform-provider-google#6340

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 374 insertions(+))
Terraform Beta: Diff ( 2 files changed, 374 insertions(+))
TF OiCS: Diff ( 8 files changed, 350 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=122652"

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few small formatting nits, otherwise good-to-go.

When you get a chance, please take a look at the release notes guide for a better understanding of how to format release notes. This specific change doesn't need one (since it's a docs and test only change), so I went ahead and removed it. Even if it had been an enhancement, though, there's a specific style we try to adhere to.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@SirGitsalot, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 374 insertions(+))
Terraform Beta: Diff ( 2 files changed, 374 insertions(+))
TF OiCS: Diff ( 8 files changed, 350 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=122925"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants