Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove path_matchers conflicts #3722

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jun 30, 2020

fixes hashicorp/terraform-provider-google#6695

Tested with the user's example config

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue in `compute_url_map` where `path_matcher` sub-fields would conflict with `default_service`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129581"

@c2thorn c2thorn requested a review from megan07 June 30, 2020 21:48
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=129582"

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@c2thorn c2thorn merged commit b5ec8e4 into GoogleCloudPlatform:master Jun 30, 2020
@c2thorn c2thorn deleted the remove_url_map_conflict branch June 30, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants