Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different port in global FR test #3725

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jul 1, 2020

Fixes hashicorp/terraform-provider-google#6657

Using the next viable port listed in https://cloud.google.com/compute/docs/reference/rest/v1/globalForwardingRules portRanges

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=130256"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccEndpointsService_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=130257"

@c2thorn c2thorn requested a review from slevenick July 1, 2020 16:26
@c2thorn c2thorn merged commit aa27fde into GoogleCloudPlatform:master Jul 1, 2020
@c2thorn c2thorn deleted the flaky-global-fr branch July 1, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants