Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make database_encryption updateable #3728

Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jul 6, 2020

Fixes hashicorp/terraform-provider-google#6733

Release Note Template for Downstream PRs (will be copied)

container: added the ability to update `database_encryption` without recreating the cluster.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 25 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 1 file changed, 25 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=131328"

@megan07 megan07 changed the title make datbase_encryption updateable make database_encryption updateable Jul 6, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 35 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 35 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=131342"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withDatabaseEncryption|TestAccEndpointsService_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=131344"

@megan07 megan07 requested review from slevenick and nat-henderson and removed request for slevenick July 6, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants