Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make iam condition ga #3729

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jul 6, 2020

Fixes hashicorp/terraform-provider-google#5952

Release Note Template for Downstream PRs (will be copied)

iam: made the `condition` block GA for all IAM resource and datasource types.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 644 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 3 files changed, 16 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=131339"

@megan07 megan07 changed the title Megan condition ga make iam condition ga Jul 6, 2020
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBinaryAuthorizationAttestorIamMemberGenerated|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccBinaryAuthorizationAttestorIamBindingGenerated|TestAccCloudFunctionsCloudFunctionIamBindingGenerated|TestAccComputeInstanceIamMemberGenerated|TestAccComputeSubnetworkIamMemberGenerated|TestAccCloudRunServiceIamMemberGenerated|TestAccDataCatalogEntryGroupIamMemberGenerated|TestAccComputeInstanceIamBindingGenerated|TestAccComputeSubnetworkIamBindingGenerated|TestAccDataCatalogEntryGroupIamBindingGenerated|TestAccCloudRunServiceIamBindingGenerated|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapWebBackendServiceIamMemberGenerated|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapWebBackendServiceIamBindingGenerated|TestAccIapWebIamMemberGenerated|TestAccIapWebTypeAppEngineIamMemberGenerated|TestAccIapWebTypeComputeIamMemberGenerated|TestAccPubsubTopicIamMemberGenerated|TestAccIapWebIamBindingGenerated|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapWebTypeAppEngineIamBindingGenerated|TestAccPubsubTopicIamBindingGenerated|TestAccIapWebTypeComputeIamBindingGenerated|TestAccRuntimeConfigConfigIamMemberGenerated|TestAccSecretManagerSecretIamMemberGenerated|TestAccRuntimeConfigConfigIamBindingGenerated|TestAccServiceManagementServiceIamMemberGenerated|TestAccSourceRepoRepositoryIamMemberGenerated|TestAccIapAppEngineServiceIamBindingGenerated|TestAccSecretManagerSecretIamBindingGenerated|TestAccServiceManagementServiceIamBindingGenerated|TestAccStorageBucketIamMemberGenerated|TestAccSourceRepoRepositoryIamBindingGenerated|TestAccStorageBucketIamBindingGenerated|TestAccBigqueryDatasetIamMember|TestAccBigqueryDatasetIamBinding|TestAccDataprocClusterIamMember|TestAccDataprocClusterIamBinding|TestAccDataprocJobIamMember|TestAccDataprocJobIamBinding|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccProjectIamBinding_withCondition|TestAccProjectIamMember_withCondition|TestAccProjectIamBinding_basic|TestAccProjectIamBinding_noMembers|TestAccProjectIamPolicy_withCondition|TestAccProjectIamBinding_multiple|TestAccProjectIamBinding_update|TestAccProjectIamMember_basic|TestAccServiceAccountIamBinding_withCondition|TestAccServiceAccountIamBinding_withAndWithoutCondition|TestAccServiceAccountIamMember_withCondition|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccServiceAccountIamBinding|TestAccServiceAccountIamPolicy_withCondition|TestAccServiceAccountIamMember|TestAccHealthcareDatasetIamMember|TestAccHealthcareDicomStoreIamMember|TestAccHealthcareDatasetIamBinding|TestAccHealthcareFhirStoreIamMember|TestAccHealthcareDicomStoreIamBinding|TestAccHealthcareHl7V2StoreIamMember|TestAccHealthcareFhirStoreIamBinding|TestAccHealthcareHl7V2StoreIamBinding|TestAccKmsCryptoKeyIamMember|TestAccKmsKeyRingIamMember|TestAccKmsCryptoKeyIamBinding|TestAccKmsKeyRingIamBinding|TestAccPubsubSubscriptionIamMember|TestAccPubsubSubscriptionIamBinding|TestAccPubsubTopicIamMember|TestAccPubsubTopicIamBinding|TestAccSpannerDatabaseIamMember|TestAccSpannerDatabaseIamBinding|TestAccSpannerInstanceIamMember|TestAccSpannerInstanceIamBinding You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=131340"

@megan07 megan07 requested a review from danawillow July 6, 2020 22:02
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, apparently I never tried to GA conditions. Here's the open issue that this fixes: hashicorp/terraform-provider-google#5952. Can you also update the changelog note to mention that it GAs it for all resource/data source types, not just policy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants