Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support healthcare dicom bq stream configure #4717

Merged
merged 15 commits into from
Apr 23, 2021
Merged

Support healthcare dicom bq stream configure #4717

merged 15 commits into from
Apr 23, 2021

Conversation

chaopeng
Copy link
Contributor

@chaopeng chaopeng commented Apr 20, 2021

healthcare dicom bq stream configure is on beta now.

Link: https://cloud.google.com/healthcare/docs/how-tos/dicom-bigquery-streaming#healthcare-streaming-dicom-metadata-cli-curl
fixes hashicorp/terraform-provider-google#8958

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

healthcare: support bq stream configure in google_healthcare_dicom_store

@google-cla google-cla bot added the cla: yes label Apr 20, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 116 insertions(+))
Terraform Beta: Diff ( 4 files changed, 241 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 129 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183262"

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaopeng thanks for the PR! Could you please update the release note according to the guidelines in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md? Thanks!

@chaopeng chaopeng requested a review from melinath April 20, 2021 21:46
@chaopeng
Copy link
Contributor Author

@melinath please run /gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 81 insertions(+))
Terraform Beta: Diff ( 3 files changed, 280 insertions(+))
TF OiCS: Diff ( 4 files changed, 152 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183275"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183276"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample|TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 81 insertions(+))
Terraform Beta: Diff ( 4 files changed, 282 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 152 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183436"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183439"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample|TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

@chaopeng chaopeng requested a review from melinath April 21, 2021 19:21
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 81 insertions(+))
Terraform Beta: Diff ( 3 files changed, 280 insertions(+))
TF OiCS: Diff ( 4 files changed, 152 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183555"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183588"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample Please fix these to complete your PR

@chaopeng chaopeng requested a review from melinath April 22, 2021 12:55
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 81 insertions(+))
Terraform Beta: Diff ( 3 files changed, 280 insertions(+))
TF OiCS: Diff ( 4 files changed, 152 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183615"

@melinath
Copy link
Member

/gcbrun - failure was unrelated.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 81 insertions(+))
Terraform Beta: Diff ( 3 files changed, 280 insertions(+))
TF OiCS: Diff ( 4 files changed, 152 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183616"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183619"

@chaopeng
Copy link
Contributor Author

chaopeng commented Apr 22, 2021

@melinath could you please share me the failure? Thank you. #4717 (comment)

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tests are all passing, so this should be good to go from that perspective. It looks like the tests use a hard-coded dataset id now; will that be an issue? It looks like that field is supposed to be a unique ID but it's not clear whether that's globally unique or within the project. It looks like the bigquery_dataset tests use a context var instead.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 81 insertions(+))
Terraform Beta: Diff ( 3 files changed, 280 insertions(+))
TF OiCS: Diff ( 4 files changed, 152 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183622"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183636"

@chaopeng chaopeng requested a review from melinath April 23, 2021 03:01
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants