Add request_reason provider support #5037

salrashid123 · 2021-08-04T22:04:29Z

fixes hashicorp/terraform-provider-google#9724

PR Description

...

provider: Add provider support for `request_reason`

modular-magician · 2021-08-04T22:04:45Z

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

modular-magician · 2021-08-04T22:05:57Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

modular-magician · 2021-08-04T22:15:42Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 12 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 13 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 5 insertions(+), 2 deletions(-))

modular-magician · 2021-08-05T00:59:20Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 16 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 17 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 5 insertions(+), 2 deletions(-))

modular-magician · 2021-08-05T13:40:58Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 16 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 17 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 5 insertions(+), 2 deletions(-))

rileykarson · 2021-08-05T17:11:16Z

Our CI got broken, would you mind rebasing? That should make it run correctly.

mmv1/third_party/terraform/utils/provider.go.erb

mmv1/third_party/terraform/utils/header_transport.go

rileykarson · 2021-08-05T17:17:12Z

mmv1/third_party/terraform/website/docs/guides/provider_reference.html.markdown

@@ -148,6 +148,8 @@ the provider should wait for a single HTTP request.  This will not adjust the
 amount of time the provider will wait for a logical operation - use the resource
 timeout blocks for that.

+* `request_reason` - (Optional) Send a Request Reason [System Parameter](https://cloud.google.com/apis/docs/system-parameters) for each API call made by the provider.  The `X-Goog-Request-Reason` header value is used to provide a user-supplied justification into GCP AuditLogs. The value set within the provider is overridden if `CLOUDSDK_CORE_REQUEST_REASON` environment variable is used.


This should be added under "Full Reference" as well. For consistency with the rest of the file, we should only include the env var there and use text like Alternatively, this can be specified using the 'CLOUDSDK_CORE_REQUEST_REASON' environment variable.

Provider config will override the environment variable w/ this implementation (which is the correct behaviour imo) so the docs should reflect as much!

melinath · 2021-08-05T17:37:06Z

/gcbrun may be all that's required (rather than needing to rebase)

salrashid123 · 2021-08-05T18:17:42Z

didn't do the rebase per previous comments but did address comments above

melinath · 2021-08-05T22:32:25Z

/gcbrun - CI issue is now resolved

modular-magician · 2021-08-05T22:42:52Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 21 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 6 files changed, 25 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-))

modular-magician · 2021-08-05T22:44:06Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 21 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 5 files changed, 23 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-))

ScottSuarez

suggest rewriting for a cleaner implementation. headerTransport is an extension of http.Header

mmv1/third_party/terraform/utils/config.go.erb

modular-magician · 2021-08-09T23:08:09Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 20 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 22 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2021-08-10T01:02:16Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=200384

mmv1/third_party/terraform/utils/provider.go.erb

rileykarson · 2021-08-10T16:41:36Z

mmv1/third_party/terraform/website/docs/guides/provider_reference.html.markdown

@@ -148,6 +148,8 @@ the provider should wait for a single HTTP request.  This will not adjust the
 amount of time the provider will wait for a logical operation - use the resource
 timeout blocks for that.

+* `request_reason` - (Optional) Send a Request Reason [System Parameter](https://cloud.google.com/apis/docs/system-parameters) for each API call made by the provider.  The `X-Goog-Request-Reason` header value is used to provide a user-supplied justification into GCP AuditLogs. The value set within the provider is overridden if `CLOUDSDK_CORE_REQUEST_REASON` environment variable is used.


Provider config will override the environment variable w/ this implementation (which is the correct behaviour imo) so the docs should reflect as much!

modular-magician · 2021-08-10T17:47:43Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 20 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 21 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2021-08-10T17:47:55Z

Error trying to cancel build ()

modular-magician · 2021-08-10T17:49:43Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 20 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 21 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2021-08-10T17:49:53Z

Error trying to cancel build ()

ScottSuarez

seems reasonable to me

mmv1/third_party/terraform/website/docs/guides/provider_reference.html.markdown

modular-magician · 2021-08-11T21:25:06Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 20 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 6 files changed, 23 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2021-08-11T21:25:27Z

Error trying to cancel build ()

modular-magician · 2021-08-11T21:25:28Z

Error trying to cancel build ()

ScottSuarez · 2021-08-11T21:49:42Z

/gcbrun

modular-magician · 2021-08-11T22:00:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 20 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 21 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2021-08-11T22:01:22Z

Error trying to cancel build ()

modular-magician · 2021-08-11T22:01:23Z

Error trying to cancel build ()

modular-magician · 2021-08-11T22:01:24Z

Error trying to cancel build ()

modular-magician · 2021-08-11T22:01:29Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=200705

modular-magician · 2021-08-12T00:25:05Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRouterPeer_advertiseMode You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=200804

rileykarson

@ScottSuarez: You looked at this more recently (w/ the linked issue below), I'll leave the merge to you

ScottSuarez · 2021-08-12T17:08:29Z

tested locally, both pathways work

Add request_reason provider support

747833e

google-cla bot added the cla: yes label Aug 4, 2021

modular-magician requested a review from rileykarson August 4, 2021 22:05

add missing check

a19b5ec

fix imports; docs

225ceee

rileykarson reviewed Aug 5, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

add default value config; docs

f7b4587

This comment has been minimized.

Sign in to view

ScottSuarez requested changes Aug 6, 2021

View reviewed changes

mmv1/third_party/terraform/utils/config.go.erb Outdated Show resolved Hide resolved

reorder addheader

e2e7cfc

rileykarson reviewed Aug 10, 2021

View reviewed changes

salrashid123 added 2 commits August 10, 2021 13:36

remove import

f3886f9

fix tab

5747365

ScottSuarez approved these changes Aug 11, 2021

View reviewed changes

rileykarson reviewed Aug 11, 2021

View reviewed changes

mmv1/third_party/terraform/website/docs/guides/provider_reference.html.markdown Outdated Show resolved Hide resolved

fix env text

ce83982

ScottSuarez mentioned this pull request Aug 12, 2021

magician dropping a test in ci run hashicorp/terraform-provider-google#9791

Closed

rileykarson approved these changes Aug 12, 2021

View reviewed changes

ScottSuarez merged commit f4804a7 into GoogleCloudPlatform:master Aug 12, 2021

khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021

Add request_reason provider support (GoogleCloudPlatform#5037)

57f844d

Add request_reason provider support #5037

Add request_reason provider support #5037

Conversation

salrashid123 commented Aug 4, 2021 • edited

modular-magician commented Aug 4, 2021

modular-magician commented Aug 4, 2021

modular-magician commented Aug 4, 2021

Diff report:

modular-magician commented Aug 5, 2021

Diff report:

modular-magician commented Aug 5, 2021

Diff report:

rileykarson commented Aug 5, 2021 • edited

rileykarson Aug 5, 2021

Choose a reason for hiding this comment

rileykarson Aug 10, 2021

Choose a reason for hiding this comment

melinath commented Aug 5, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

salrashid123 commented Aug 5, 2021

This comment has been minimized.

melinath commented Aug 5, 2021 • edited

modular-magician commented Aug 5, 2021

Diff report:

modular-magician commented Aug 5, 2021

Diff report:

ScottSuarez left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 9, 2021

Diff report:

modular-magician commented Aug 10, 2021

rileykarson Aug 10, 2021

Choose a reason for hiding this comment

modular-magician commented Aug 10, 2021

Diff report:

modular-magician commented Aug 10, 2021

modular-magician commented Aug 10, 2021

Diff report:

modular-magician commented Aug 10, 2021

ScottSuarez left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 11, 2021

Diff report:

modular-magician commented Aug 11, 2021

modular-magician commented Aug 11, 2021

ScottSuarez commented Aug 11, 2021

modular-magician commented Aug 11, 2021

Diff report:

modular-magician commented Aug 11, 2021

modular-magician commented Aug 11, 2021

modular-magician commented Aug 11, 2021

modular-magician commented Aug 11, 2021

modular-magician commented Aug 12, 2021

rileykarson left a comment • edited

Choose a reason for hiding this comment

ScottSuarez commented Aug 12, 2021

salrashid123 commented Aug 4, 2021 •

edited

rileykarson commented Aug 5, 2021 •

edited

melinath commented Aug 5, 2021 •

edited

rileykarson left a comment •

edited