Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HashiCorp Learn documentation #5040

Merged
merged 2 commits into from Aug 5, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Aug 5, 2021

Upstreams hashicorp/terraform-provider-google#9725

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


judithpatudith and others added 2 commits August 5, 2021 11:17
Add links to our GCP tutorials to the documentation for the GCP provider.
Co-authored-by: megan07 <mbang@hashicorp.com>
@google-cla
Copy link

google-cla bot commented Aug 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 5, 2021
@megan07 megan07 requested a review from c2thorn August 5, 2021 16:18
@megan07 megan07 changed the title Megan upstream learn Adding HashiCorp Learn documentation Aug 5, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 3 insertions(+))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 1 deletion(-))

@megan07 megan07 merged commit 7a3b600 into GoogleCloudPlatform:master Aug 5, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
* Add Learn links to GCP provider docs

Add links to our GCP tutorials to the documentation for the GCP provider.

* Update website/docs/index.html.markdown

Co-authored-by: megan07 <mbang@hashicorp.com>

Co-authored-by: Judith Malnick <judith.patudith@gmail.com>
Co-authored-by: Judith Malnick <judith@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants