Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IP addresses so that BGP sessions come up successfully #5159

Merged

Conversation

betsy-lichtenberg
Copy link
Contributor

BGP sessions said "waiting for peer." With this fix, the BGP sessions say "established."

@google-cla google-cla bot added the cla: yes label Aug 31, 2021
@betsy-lichtenberg betsy-lichtenberg changed the title Fixed IP addresses so that BGP session comes up successfully Fixed IP addresses so that BGP sessions come up successfully Aug 31, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 4 files changed, 10 insertions(+), 10 deletions(-))
TF OiCS: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
TF Cloud Doc Samples: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=203656

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline Please fix these to complete your PR

@melinath

This comment has been minimized.

@melinath

This comment has been minimized.

@melinath
Copy link
Member

melinath commented Aug 31, 2021

Trying to run TestAccComputeHaVpnGateway_haVpnGatewayGcpToGcpExample - skipped in VCR mode https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/203688

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - test passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants