Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated go.mod and go.sum #5194

Merged

Conversation

kubasieron
Copy link
Contributor

@kubasieron kubasieron commented Sep 13, 2021

Updated go.sum and go.mod.erb to be compatible with go API 0.56.0

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@google-cla google-cla bot added the cla: yes label Sep 13, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 54 insertions(+), 230 deletions(-))
Terraform Beta: Diff ( 5 files changed, 56 insertions(+), 234 deletions(-))

@ScottSuarez
Copy link
Contributor

pushed a change to unblock this

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 62 insertions(+), 236 deletions(-))
Terraform Beta: Diff ( 4 files changed, 63 insertions(+), 239 deletions(-))

@ScottSuarez
Copy link
Contributor

/gcbrun just pushed a new version of the builder. hopefully that will resolve the downstream diff

@ScottSuarez
Copy link
Contributor

/gcbrun

5 similar comments
@ScottSuarez
Copy link
Contributor

/gcbrun

@ScottSuarez
Copy link
Contributor

/gcbrun

@ScottSuarez
Copy link
Contributor

/gcbrun

@ScottSuarez
Copy link
Contributor

/gcbrun

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 61 insertions(+), 235 deletions(-))
Terraform Beta: Diff ( 2 files changed, 61 insertions(+), 235 deletions(-))

@rileykarson
Copy link
Member

@ScottSuarez watch out for changelogs! This was type enhancement with no user-facing change, so should have been marked as none.

khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
Co-authored-by: Scott Suarez <ScottMSuarez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants