Add support for NEG type PRIVATE_SERVICE_CONNECT in NetworkEndpointGroup

[xuchenma]

This PR adds support for NEG type PRIVATE_SERVICE_CONNECT in NetworkEndpointGroup, which solves hashicorp/terraform-provider-google#11631

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added support for NEG type `PRIVATE_SERVICE_CONNECT` in `NetworkEndpointGroup`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 90 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 5 files changed, 90 insertions(+), 11 deletions(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 108 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2014
Passed tests 1780
Skipped tests: 231
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscExample|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscExample[view]

Tests failed during RECORDING mode:
TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[ScottSuarez]

Any reason the exactly one of blocks are being removed here?

[xuchenma]

Any reason the exactly one of blocks are being removed here?

Those parameters are only valid when networkEndpointType is "SERVERLESS". They shouldn't be set when networkEndpointType is "PRIVATE_SERVICE_CONNECT".

[ScottSuarez]

Should exactly one of not just be extended to include networkEndpointType then?

[xuchenma]

Should exactly one of not just be extended to include networkEndpointType then?

I'm not sure I follow this. networkEndpointType is an Enum, it used to only have one value SERVERLESS. When it is SERVERLESS, there has to be "exactly one of" those blocks specified.
This PR adds PRIVATE_SERVICE_CONNECT to the Enum. When that is chosen, none of the previous "exactly one of" blocks should be set.

[ScottSuarez]

Sorry perhaps ConflictsWith would be more apt for this usecase.

My concern is making sure fields are not set when they are not able.

[xuchenma]

That makes sense. Can you link an example that uses ConflictsWith ?

[ScottSuarez]

Sure !
https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/compute/api.yaml#L3596-L3605

[xuchenma]

Thanks! However if I understand correctly, in the example, conflicts seems to be used when two parameters A and B cannot be set at the same time.
In this PR, I'm trying to describe that:

• when A is set to a1, B can be set
• when A is set to a2, B cannot be set

Is that doable with conflicts?

[ScottSuarez]

While this is true for A, b continues to conflict with c, d, and e. Those properties continue to be unable to be set together, correct?

[xuchenma]

Oh I see, updated!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 89 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 94 insertions(+), 11 deletions(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 108 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2018
Passed tests 1786
Skipped tests: 231
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample

[modular-magician]

Tests failed during RECORDING mode:
TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[ScottSuarez]

lgtm