-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storagetransfer transferoptions perm diff #6063
Fix storagetransfer transferoptions perm diff #6063
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 135 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccStorageTransferJob_transfreOptions |
@slevenick could you take a look here. Looks like you authored a PR referenced here and might have more context for a review |
@slevenick Could you please take a look this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine other than a typo in the test name
mmv1/third_party/terraform/tests/resource_storage_transfer_job_test.go
Outdated
Show resolved
Hide resolved
…_test.go Co-authored-by: Sam Levenick <slevenick@google.com>
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 135 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccStorageTransferJob_transferOptions|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withAddons|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccComputeSecurityPolicy_withAdvancedOptionsConfig |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Fix #11744
There was a issue with transferOptions always returning from API when using posix,
I think This fix added, probably.
but it had too large effect to other cases.
So I fixed to use only posix case.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)