Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storagetransfer transferoptions perm diff #6063

Conversation

yudoufu
Copy link
Contributor

@yudoufu yudoufu commented May 22, 2022

Fix #11744

There was a issue with transferOptions always returning from API when using posix,
I think This fix added, probably.
but it had too large effect to other cases.
So I fixed to use only posix case.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storagetransfer: fixed perm diff on transfer_options for `google_storage_transfer_job`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@yudoufu yudoufu changed the title Fix stragetransfer transferoptions perm diff Fix storagetransfer transferoptions perm diff May 22, 2022
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 135 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 135 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2023
Passed tests 1796
Skipped tests: 226
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccStorageTransferJob_transfreOptions

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccStorageTransferJob_transfreOptions[view]

All tests passed
View the build log or the debug log for each test

@ScottSuarez
Copy link
Contributor

@slevenick could you take a look here. Looks like you authored a PR referenced here and might have more context for a review

@yudoufu
Copy link
Contributor Author

yudoufu commented May 30, 2022

@slevenick Could you please take a look this PR?

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine other than a typo in the test name

…_test.go

Co-authored-by: Sam Levenick <slevenick@google.com>
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 135 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 135 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2032
Passed tests 1792
Skipped tests: 226
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccStorageTransferJob_transferOptions|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withAddons|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccComputeSecurityPolicy_withAdvancedOptionsConfig

@yudoufu yudoufu requested a review from slevenick June 2, 2022 18:44
@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeSecurityPolicy_withAdvancedOptionsConfig[view]
TestAccContainerCluster_withSandboxConfig[view]
TestAccStorageTransferJob_transferOptions[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType[view]
TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform[view]
TestAccContainerCluster_nodeAutoprovisioningDefaults[view]
TestAccContainerCluster_withBootDiskKmsKey[view]
TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion[view]
TestAccContainerCluster_withWorkloadMetadataConfig[view]
TestAccContainerCluster_updateVersion[view]
TestAccContainerCluster_withVersion[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withNotificationConfig[view]
TestAccContainerCluster_withConfidentialNodes[view]
TestAccContainerCluster_withAddons[view]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants