-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support include of name cookies #6092
feat: support include of name cookies #6092
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
c2747f5
to
496eb98
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 70 insertions(+), 10 deletions(-)) |
@megan07 i'm getting some issue when doing
|
@megan07 Additionally I don't have an example to add the additional property? Do I need to create a new example? |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeBackendService_withCdnPolicy |
@gboston thank you so much for your contribution! An example would be great, a simple way to do it would be to create a file like this one and add your use case configuration, you'll then refer to it like so here. Let me know if you have further questions and I can help you with this. Our acceptance tests ran here and looked good, however, once you add the new example we'll need to re-run with that example (which will happen again on the PR, so no worries there). As for the lint errors, they look to be unrelated to your changes, so I'll run Thanks again! |
@megan07 example has been added. |
mmv1/templates/terraform/examples/backend_service_cache_include_named_cookies.erb
Outdated
Show resolved
Hide resolved
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 131 insertions(+), 10 deletions(-)) |
@megan07 i'm unable to see the build issues on Cloud Build. Do I need to do something to get additional access? |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccBillingSubaccount_renameOnDestroy|TestAccBillingSubaccount_basic|TestAccContainerClusterDatasource_regional|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withVersion|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withTpu|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_regional|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerNodePool_withSandboxConfig|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withConfidentialNodes|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAddons|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerNodePool_withNodeConfig|TestAccContainerCluster_misc|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_backend|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_basic|TestAccContainerCluster_network|TestAccContainerCluster_withSandboxConfig|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_basicWithClusterId|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerNodePool_basic|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample |
The provider crashed while running the VCR tests in RECORDING mode |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 131 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withVersion|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
mmv1/templates/terraform/examples/backend_service_cache_include_named_cookies.tf.erb
Outdated
Show resolved
Hide resolved
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 141 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAddons|TestAccBillingSubaccount_basic|TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
* feat: support include of name cookies * chore: add example * fix: adjust typo * fix: adjust example name * chore: rename file to .tf.erb * chore: use real life example
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)