Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support include of name cookies #6092

Merged

Conversation

gboston
Copy link
Contributor

@gboston gboston commented May 31, 2022

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `include_named_cookies` to `cdn_policy` on `compute_backend_service` resource

@google-cla
Copy link

google-cla bot commented May 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@gboston gboston force-pushed the feat/include-named-cookies branch from c2747f5 to 496eb98 Compare May 31, 2022 12:58
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 70 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 4 files changed, 70 insertions(+), 10 deletions(-))
TF Validator: Diff ( 4 files changed, 25 insertions(+), 3 deletions(-))

@gboston
Copy link
Contributor Author

gboston commented May 31, 2022

@megan07 i'm getting some issue when doing make lint on the terraform-provider-google repo:

google/resource_compute_instance_migrate_test.go:586:3: S1038: should use t.Skipf(...) instead of t.Skip(fmt.Sprintf(...)) (gosimple)
		t.Skip(fmt.Sprintf("Network access not allowed; use %s=1 to enable", TestEnvVar))
		^
google/resource_compute_instance_migrate_test.go:659:3: S1038: should use t.Skipf(...) instead of t.Skip(fmt.Sprintf(...)) (gosimple)
		t.Skip(fmt.Sprintf("Network access not allowed; use %s=1 to enable", TestEnvVar))
		^
google/resource_compute_instance_migrate_test.go:731:3: S1038: should use t.Skipf(...) instead of t.Skip(fmt.Sprintf(...)) (gosimple)
		t.Skip(fmt.Sprintf("Network access not allowed; use %s=1 to enable", TestEnvVar))
		^
google/resource_compute_instance_migrate_test.go:797:3: S1038: should use t.Skipf(...) instead of t.Skip(fmt.Sprintf(...)) (gosimple)
		t.Skip(fmt.Sprintf("Network access not allowed; use %s=1 to enable", TestEnvVar))
```

@gboston gboston marked this pull request as ready for review May 31, 2022 13:38
@gboston
Copy link
Contributor Author

gboston commented May 31, 2022

@megan07 Additionally I don't have an example to add the additional property? Do I need to create a new example?
Next up I didn't run any acceptance tests, is this also done on PR?

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2028
Passed tests 1801
Skipped tests: 226
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccComputeBackendService_withCdnPolicy

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeBackendService_withCdnPolicy[view]

All tests passed
View the build log or the debug log for each test

@megan07
Copy link
Contributor

megan07 commented May 31, 2022

@gboston thank you so much for your contribution!

An example would be great, a simple way to do it would be to create a file like this one and add your use case configuration, you'll then refer to it like so here. Let me know if you have further questions and I can help you with this.

Our acceptance tests ran here and looked good, however, once you add the new example we'll need to re-run with that example (which will happen again on the PR, so no worries there).

As for the lint errors, they look to be unrelated to your changes, so I'll run make lint locally to see if it's something we can address outside your PR.

Thanks again!

@gboston
Copy link
Contributor Author

gboston commented May 31, 2022

@megan07 example has been added.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 131 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 5 files changed, 131 insertions(+), 10 deletions(-))
TF Validator: Diff ( 4 files changed, 25 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

@gboston
Copy link
Contributor Author

gboston commented Jun 1, 2022

@megan07 i'm unable to see the build issues on Cloud Build. Do I need to do something to get additional access?

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2031
Passed tests 1721
Skipped tests: 226
Failed tests: 84

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccBillingSubaccount_renameOnDestroy|TestAccBillingSubaccount_basic|TestAccContainerClusterDatasource_regional|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withVersion|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withTpu|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_regional|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerNodePool_withSandboxConfig|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withConfidentialNodes|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAddons|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerNodePool_withNodeConfig|TestAccContainerCluster_misc|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_backend|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_basic|TestAccContainerCluster_network|TestAccContainerCluster_withSandboxConfig|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_basicWithClusterId|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerNodePool_basic|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample

@modular-magician
Copy link
Collaborator

The provider crashed while running the VCR tests in RECORDING mode
Please fix it to complete your PR
View the build log

@megan07
Copy link
Contributor

megan07 commented Jun 1, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 131 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 5 files changed, 131 insertions(+), 10 deletions(-))
TF Validator: Diff ( 4 files changed, 25 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2031
Passed tests 1788
Skipped tests: 226
Failed tests: 17

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withVersion|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_withNodePoolUpdateVersion[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform[view]
TestAccContainerCluster_withWorkloadIdentityConfig[view]
TestAccContainerCluster_errorAutopilotLocation[view]
TestAccContainerCluster_withAutopilot[view]
TestAccContainerCluster_nodeAutoprovisioningDefaults[view]
TestAccContainerCluster_withVersion[view]
TestAccContainerCluster_withBootDiskKmsKey[view]
TestAccContainerCluster_withSandboxConfig[view]
TestAccContainerCluster_withWorkloadMetadataConfig[view]
TestAccContainerCluster_updateVersion[view]
TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion[view]

Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample[view]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType[view]
TestAccContainerCluster_withConfidentialNodes[view]
TestAccContainerCluster_withNotificationConfig[view]
TestAccContainerCluster_withAddons[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 141 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 5 files changed, 141 insertions(+), 10 deletions(-))
TF Validator: Diff ( 4 files changed, 25 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2033
Passed tests 1802
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAddons|TestAccBillingSubaccount_basic|TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample[view]
TestAccBillingSubaccount_basic[view]
TestAccContainerCluster_withNotificationConfig[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withConfidentialNodes[view]
TestAccContainerCluster_withAddons[view]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@megan07 megan07 merged commit 9de400f into GoogleCloudPlatform:main Jun 3, 2022
TheSpiritXIII pushed a commit to TheSpiritXIII/magic-modules that referenced this pull request Jun 3, 2022
* feat: support include of name cookies

* chore: add example

* fix: adjust typo

* fix: adjust example name

* chore: rename file to .tf.erb

* chore: use real life example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants