Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected provider setup for a few cgc examples #6145

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Corrected provider setup for a few cgc examples #6145

merged 2 commits into from
Jun 17, 2022

Conversation

melinath
Copy link
Member

@melinath melinath commented Jun 17, 2022

Fixed provider for some beta-only tests. Related to hashicorp/terraform-provider-google#11825

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 91 deletions(-))
Terraform Beta: Diff ( 1 file changed, 13 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Cloud Doc Samples: Diff ( 3 files changed, 12 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2053
Passed tests 1825
Skipped tests: 226
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@melinath
Copy link
Member Author

melinath commented Jun 17, 2022

@melinath melinath requested a review from cbonnie June 17, 2022 20:11
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 91 deletions(-))
Terraform Beta: Diff ( 1 file changed, 17 insertions(+), 8 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Cloud Doc Samples: Diff ( 3 files changed, 16 insertions(+), 7 deletions(-))

@melinath melinath requested review from a team and shuyama1 and removed request for a team June 17, 2022 20:51
@melinath melinath marked this pull request as ready for review June 17, 2022 20:51
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2053
Passed tests 1823
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccSqlUser_mysqlDisabled

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSqlUser_mysqlDisabled[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@cbonnie cbonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants