compute_snapshot datasource added #6527

AarshDhokai · 2022-09-09T07:14:00Z

fixes hashicorp/terraform-provider-google#3382

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_snapshot'

modular-magician · 2022-09-09T07:14:58Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-09-09T07:25:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 445 insertions(+))
Terraform Beta: Diff ( 4 files changed, 445 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-09T07:27:05Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2022-09-09T09:00:25Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 443 insertions(+))
Terraform Beta: Diff ( 4 files changed, 443 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-09T09:01:29Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2022-09-09T09:32:17Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 442 insertions(+))
Terraform Beta: Diff ( 4 files changed, 442 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-09T09:33:09Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

rileykarson

This is failing to build- holding on review until that passes.

Also, can you format the release note according to the release notes guide? Thanks!

modular-magician · 2022-09-14T09:08:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 442 insertions(+))
Terraform Beta: Diff ( 4 files changed, 442 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-14T09:10:02Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2022-09-14T09:29:54Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 442 insertions(+))
Terraform Beta: Diff ( 4 files changed, 442 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-14T10:21:46Z

Tests analytics

Total tests: 2174
Passed tests 1930
Skipped tests: 238
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccSnapshotDatasource_filter_mostRecent|TestAccSnapshotDatasource_filter|TestAccSnapshotDatasource_name|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-14T10:27:03Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccSnapshotDatasource_filter_mostRecent[Debug log]
TestAccSnapshotDatasource_filter[Debug log]
TestAccSnapshotDatasource_name[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson

What issue(s) does this PR address? The filter and most_recent behaviour are not standard for a single-resource datasource, so I want to make sure we're not introducing additional complexity / surface we have to maintain without a justification.

AarshDhokai · 2022-09-15T05:05:06Z

What issue(s) does this PR address? The filter and most_recent behaviour are not standard for a single-resource datasource, so I want to make sure we're not introducing additional complexity / surface we have to maintain without a justification.

This PR addresses this issue - Disk snapshot data source #3382 .

mmv1/third_party/terraform/website/docs/d/compute_snapshot.html.markdown

rileykarson · 2022-09-15T16:49:09Z

mmv1/third_party/terraform/utils/provider.go.erb

@@ -232,6 +232,7 @@ func Provider() *schema.Provider {
 			"google_compute_resource_policy":                   dataSourceGoogleComputeResourcePolicy(),
 			"google_compute_router":                            dataSourceGoogleComputeRouter(),
 			"google_compute_router_status":                     dataSourceGoogleComputeRouterStatus(),
+			"google_compute_snapshot":							dataSourceGoogleComputeSnapshot(),


nit: The spacing here uses tabs rather than spaces.

mmv1/third_party/terraform/website/docs/d/compute_snapshot.html.markdown

mmv1/third_party/terraform/data_sources/data_source_google_compute_snapshot.go.erb

mmv1/third_party/terraform/website/docs/d/compute_snapshot.html.markdown

rileykarson · 2022-09-15T19:45:37Z

Thanks! The issue clarifies why we'd want those behaviours.

…shot

…r user project overrides on new api calls, and fix the documentation

…nto data_source_compute_snapshot

…shDhokai/magic-modules into data_source_compute_snapshot

modular-magician · 2022-09-17T13:59:36Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 370 insertions(+))
Terraform Beta: Diff ( 4 files changed, 370 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-17T15:04:07Z

Tests analytics

Total tests: 2177
Passed tests 1935
Skipped tests: 238
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSnapshotDatasource_filter_mostRecent|TestAccSnapshotDatasource_filter

modular-magician · 2022-09-17T15:09:17Z

Tests passed during RECORDING mode:
TestAccSnapshotDatasource_filter_mostRecent[Debug log]
TestAccSnapshotDatasource_filter[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson

Couple minor comments, otherwise looks good!

mmv1/third_party/terraform/data_sources/data_source_google_compute_snapshot.go.erb

mmv1/third_party/terraform/tests/data_source_google_compute_snapshot_test.go

mmv1/third_party/terraform/website/docs/d/compute_snapshot.html.markdown

modular-magician · 2022-09-22T19:56:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 369 insertions(+))
Terraform Beta: Diff ( 4 files changed, 369 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-22T20:46:26Z

Tests analytics

Total tests: 2179
Passed tests 1935
Skipped tests: 238
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSnapshotDatasource_filterMostRecent

modular-magician · 2022-09-22T20:49:16Z

Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccSnapshotDatasource_filterMostRecent[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-23T05:16:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 369 insertions(+))
Terraform Beta: Diff ( 4 files changed, 369 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-23T06:27:49Z

Tests analytics

Total tests: 2181
Passed tests 1941
Skipped tests: 238
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician · 2022-09-23T06:33:41Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

AarshDhokai · 2022-09-28T05:24:36Z

Hi @rileykarson, Could you please Merge this PR as it's approved?

modular-magician requested a review from rileykarson September 9, 2022 07:14

rileykarson reviewed Sep 13, 2022

View reviewed changes

modular-magician requested a review from rileykarson September 14, 2022 08:56

AarshDhokai added 5 commits September 14, 2022 09:18

compute_snapshot datasource added

451164c

recommit for running test cases of the PR

12adb6d

commitimg for running test again

9183d5a

data_source_google_compute_snapshot.go.erb added

96133f4

added the erb file for compute snapshot data source

6874b3e

AarshDhokai force-pushed the data_source_compute_snapshot branch from 38d574c to 6874b3e Compare September 14, 2022 09:19

AarshDhokai marked this pull request as draft September 14, 2022 12:29

AarshDhokai marked this pull request as ready for review September 14, 2022 12:29

rileykarson requested changes Sep 14, 2022

View reviewed changes

rileykarson reviewed Sep 15, 2022

View reviewed changes

Merge branch 'GoogleCloudPlatform:main' into data_source_compute_snap…

dea9f4d

…shot

modular-magician requested a review from rileykarson September 17, 2022 13:39

Handle the pagination for sorting of the snapshots, ensure support fo…

30eac1c

…r user project overrides on new api calls, and fix the documentation

AarshDhokai added 2 commits September 17, 2022 13:46

Merge branch 'main' of https://github.com/AarshDhokai/magic-modules i…

ae734c3

…nto data_source_compute_snapshot

Merge branch 'data_source_compute_snapshot' of https://github.com/Aar…

90c310d

…shDhokai/magic-modules into data_source_compute_snapshot

rileykarson reviewed Sep 22, 2022

View reviewed changes

Minor fixes

194ff56

modular-magician requested a review from rileykarson September 22, 2022 19:46

rileykarson approved these changes Sep 22, 2022

View reviewed changes

fixing tabs in provider.go.erb

9b15e67

modular-magician requested a review from rileykarson September 23, 2022 05:04

rileykarson merged commit 8130a60 into GoogleCloudPlatform:main Sep 28, 2022

This was referenced Sep 28, 2022

compute_snapshot datasource added hashicorp/terraform-provider-google-beta#4731

Merged

compute_snapshot datasource added hashicorp/terraform-provider-google#12671

Merged

compute_snapshot datasource added GoogleCloudPlatform/terraform-validator#1007

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compute_snapshot datasource added #6527

compute_snapshot datasource added #6527

AarshDhokai commented Sep 9, 2022 •

edited

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

rileykarson left a comment

modular-magician commented Sep 14, 2022

modular-magician commented Sep 14, 2022

modular-magician commented Sep 14, 2022

modular-magician commented Sep 14, 2022

modular-magician commented Sep 14, 2022

rileykarson left a comment

AarshDhokai commented Sep 15, 2022

rileykarson Sep 15, 2022

AarshDhokai Sep 23, 2022

rileykarson commented Sep 15, 2022

modular-magician commented Sep 17, 2022

modular-magician commented Sep 17, 2022

modular-magician commented Sep 17, 2022

rileykarson left a comment

modular-magician commented Sep 22, 2022

modular-magician commented Sep 22, 2022

modular-magician commented Sep 22, 2022

modular-magician commented Sep 23, 2022

modular-magician commented Sep 23, 2022

modular-magician commented Sep 23, 2022

AarshDhokai commented Sep 28, 2022

compute_snapshot datasource added #6527

compute_snapshot datasource added #6527

Conversation

AarshDhokai commented Sep 9, 2022 • edited

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 9, 2022

Tests analytics

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 9, 2022

Tests analytics

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 9, 2022

Tests analytics

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Sep 14, 2022

Diff report:

modular-magician commented Sep 14, 2022

Tests analytics

modular-magician commented Sep 14, 2022

Diff report:

modular-magician commented Sep 14, 2022

Tests analytics

Action taken

modular-magician commented Sep 14, 2022

rileykarson left a comment

Choose a reason for hiding this comment

AarshDhokai commented Sep 15, 2022

rileykarson Sep 15, 2022

Choose a reason for hiding this comment

AarshDhokai Sep 23, 2022

Choose a reason for hiding this comment

rileykarson commented Sep 15, 2022

modular-magician commented Sep 17, 2022

Diff report:

modular-magician commented Sep 17, 2022

Tests analytics

Action taken

modular-magician commented Sep 17, 2022

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Sep 22, 2022

Diff report:

modular-magician commented Sep 22, 2022

Tests analytics

Action taken

modular-magician commented Sep 22, 2022

modular-magician commented Sep 23, 2022

Diff report:

modular-magician commented Sep 23, 2022

Tests analytics

Action taken

modular-magician commented Sep 23, 2022

AarshDhokai commented Sep 28, 2022

AarshDhokai commented Sep 9, 2022 •

edited