Adding Eventarc GoogleChannelConfig Resource support for TPG #6534

daveavi · 2022-09-10T19:18:04Z

I have made changes to the magic-modules repo to support a new resource the Eventarc team has created, called GoogleChannelConfig. It is a regional singleton resource that enables customers to proctect their data with encryption for all first party triggers.

Fixes: hashicorp/terraform-provider-google#12520

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_eventarc_google_channel_config

…n basic.tf.tmpl file

modular-magician · 2022-09-10T19:29:52Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 279 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 577 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-10T20:36:24Z

Tests analytics

Total tests: 2171
Passed tests 1879
Skipped tests: 236
Failed tests: 56

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccEventarcGoogleChannelConfig_BasicHandWritten|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_router|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeRouterInterface_basic|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRouterPeer_basic|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_networkTier|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeForwardingRule_ip|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleForwardingRule|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyAssociation_basic

modular-magician · 2022-09-10T21:56:38Z

Tests passed during RECORDING mode:
TestAccEventarcGoogleChannelConfig_BasicHandWritten[Debug log]
TestAccComputeVpnTunnel_regionFromGateway[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log]
TestAccCloudRunService_cloudRunServiceMultipleRegionsExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccDataSourceGoogleGlobalForwardingRule[Debug log]
TestAccDataSourceGoogleForwardingRule[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson · 2022-09-13T20:09:40Z

note: holding review for #6529 to get merged (or ready for merge), since I'd imagine comments will be similar between them

modular-magician · 2022-09-13T22:29:20Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 319 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 617 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-13T23:39:07Z

Tests analytics

Total tests: 2173
Passed tests 1895
Skipped tests: 238
Failed tests: 40

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate|TestAccEventarcGoogleChannelConfig_basic|TestAccComputeRouterInterface_withTunnel|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRouterInterface_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRoute_routeIlbVipExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyAssociation_basic

modular-magician · 2022-09-14T00:30:06Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log]
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log]
TestAccComputeGlobalForwardingRule_updateTarget[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeFirewallPolicy_update[Debug log]
TestAccComputeFirewallPolicyAssociation_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-19T13:01:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 312 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 610 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-19T14:05:09Z

Tests analytics

Total tests: 2176
Passed tests 1915
Skipped tests: 238
Failed tests: 23

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate|TestAccEventarcGoogleChannelConfig_basic|TestAccComputeVpnTunnel_router|TestAccComputeRouterInterface_withTunnel|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_networkTier|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeForwardingRule_ip|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-19T14:14:16Z

Tests passed during RECORDING mode:
TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate[Debug log]
TestAccEventarcGoogleChannelConfig_basic[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccComputeGlobalForwardingRule_ipv6[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson

Couple minor points- some formatting and a stray file- but otherwise good to merge once the DCL version's been updated in a separate PR and we've rebased or otherwise resolved the merge conflicts.

tpgtools/api/eventarc/samples/copy.py

mmv1/third_party/terraform/tests/resource_eventarc_google_channel_config_test.go.erb

modular-magician · 2022-09-19T23:27:13Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 312 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 610 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-20T00:19:36Z

Tests analytics

Total tests: 2178
Passed tests 1931
Skipped tests: 238
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeVpnTunnel_router|TestAccComputeRouterInterface_withTunnel|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-20T00:25:00Z

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-22T17:31:01Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 311 insertions(+))
Terraform Beta: Diff ( 5 files changed, 609 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-22T18:36:21Z

Tests analytics

Total tests: 2178
Passed tests 1929
Skipped tests: 238
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeVpnTunnel_router|TestAccComputeRouterPeer_bfd|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployTarget_Target|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-22T18:41:30Z

Tests passed during RECORDING mode:
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccClouddeployTarget_Target[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…i/magic-modules into add-google-channel-config

modular-magician · 2022-09-27T18:22:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 12 files changed, 541 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 14 files changed, 839 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-27T19:34:43Z

Tests analytics

Total tests: 2183
Passed tests 1925
Skipped tests: 238
Failed tests: 20

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeVpnTunnel_router|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccClouddeployTarget_Target|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccPrivatecaCaPoolIamPolicyGenerated_withCondition|TestAccFirebaserulesRelease_BasicRelease|TestAccStorageTransferJob_transferOptions|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccComputeInstanceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeBackendServiceIamPolicyGenerated_withCondition

modular-magician · 2022-09-27T19:39:13Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccPrivatecaCaPoolIamPolicyGenerated_withCondition[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccStorageTransferJob_transferOptions[Debug log]
TestAccComputeMachineImageIamPolicyGenerated_withCondition[Debug log]
TestAccComputeInstanceIamPolicyGenerated_withCondition[Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Debug log]
TestAccComputeBackendServiceIamPolicyGenerated_withCondition[Debug log]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccClouddeployTarget_Target[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccOrgPolicyPolicy_FolderPolicy[Error message] [Debug log]
TestAccOrgPolicyPolicy_ProjectPolicy[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-11-07T22:24:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 309 insertions(+))
Terraform Beta: Diff ( 4 files changed, 607 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-07T23:12:26Z

Tests analytics

Total tests: 2224
Passed tests 1982
Skipped tests: 240
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_update

modular-magician · 2022-11-07T23:17:27Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

rileykarson

Two small comments, one inline and one here;

We'll need to add a GA copy of tpgtools/overrides/eventarc/beta/google_channel_config.yaml as well, this currently only adds a beta version of the resource.

mmv1/third_party/terraform/tests/resource_eventarc_google_channel_config_test.go.erb

…n hand written test

modular-magician · 2022-11-15T01:13:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 606 insertions(+))
Terraform Beta: Diff ( 4 files changed, 606 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-15T01:57:53Z

Tests analytics

Total tests: 2256
Passed tests 2012
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_update

modular-magician · 2022-11-15T02:00:32Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

rileykarson

LGTM, thanks!

daveavi · 2022-11-18T18:28:23Z

Thanks Riley!

…loudPlatform#6534) Fixes hashicorp/terraform-provider-google#12520

daveavi added 3 commits September 9, 2022 23:04

feat: adding google channel config

d0f7911

fix: updating dcl to v1.20.1

006add5

fix: changed name of resource from channel to google channel config i…

641d725

…n basic.tf.tmpl file

daveavi requested a review from rileykarson as a code owner September 10, 2022 19:18

fix: updating pr based on changes I made for eventarc channel

9780124

nit: changed formatting based on comments on PR for channel

7b6780e

rileykarson reviewed Sep 19, 2022

View reviewed changes

tpgtools/api/eventarc/samples/copy.py Outdated Show resolved Hide resolved

mmv1/third_party/terraform/tests/resource_eventarc_google_channel_config_test.go.erb Outdated Show resolved Hide resolved

fix: deleted python script

bd9e1a3

modular-magician requested a review from rileykarson September 19, 2022 23:12

daveavi added 2 commits September 19, 2022 23:13

fix: updated format of template file of google_channel_config_test

93f9635

fix: fix formatting issues with tabs

9846b60

Merge branch 'main' into add-google-channel-config

9738e56

daveavi added 2 commits September 27, 2022 17:22

feat: upgrade to dcl v1.22.1

a4f5862

Merge branch 'add-google-channel-config' of https://github.com/daveav…

7b66979

…i/magic-modules into add-google-channel-config

Merge branch 'main' into add-google-channel-config

d2e45dd

Merge branch 'main' into add-google-channel-config

7ac519c

rileykarson reviewed Nov 15, 2022

View reviewed changes

mmv1/third_party/terraform/tests/resource_eventarc_google_channel_config_test.go.erb Outdated Show resolved Hide resolved

fix: added google channel config yaml in GA and changed dcl version i…

bcd5767

…n hand written test

modular-magician requested a review from rileykarson November 15, 2022 00:57

rileykarson approved these changes Nov 18, 2022

View reviewed changes

rileykarson merged commit 6b80c15 into GoogleCloudPlatform:main Nov 18, 2022

This was referenced Nov 18, 2022

Adding Eventarc GoogleChannelConfig Resource support for TPG hashicorp/terraform-provider-google-beta#4905

Merged

Adding Eventarc GoogleChannelConfig Resource support for TPG hashicorp/terraform-provider-google#13080

Merged

googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 22, 2022

Adding Eventarc GoogleChannelConfig Resource support for TPG (GoogleC…

e993be7

…loudPlatform#6534) Fixes hashicorp/terraform-provider-google#12520

googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 25, 2022

Adding Eventarc GoogleChannelConfig Resource support for TPG (GoogleC…

9954279

…loudPlatform#6534) Fixes hashicorp/terraform-provider-google#12520

kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Dec 6, 2022

Adding Eventarc GoogleChannelConfig Resource support for TPG (GoogleC…

9857c37

…loudPlatform#6534) Fixes hashicorp/terraform-provider-google#12520

hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022

Adding Eventarc GoogleChannelConfig Resource support for TPG (GoogleC…

d315de6

…loudPlatform#6534) Fixes hashicorp/terraform-provider-google#12520

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Eventarc GoogleChannelConfig Resource support for TPG #6534

Adding Eventarc GoogleChannelConfig Resource support for TPG #6534

daveavi commented Sep 10, 2022 •

edited by rileykarson

modular-magician commented Sep 10, 2022

modular-magician commented Sep 10, 2022

modular-magician commented Sep 10, 2022

rileykarson commented Sep 13, 2022

modular-magician commented Sep 13, 2022

modular-magician commented Sep 13, 2022

modular-magician commented Sep 14, 2022

modular-magician commented Sep 19, 2022

modular-magician commented Sep 19, 2022

modular-magician commented Sep 19, 2022

rileykarson left a comment

modular-magician commented Sep 19, 2022

modular-magician commented Sep 20, 2022

modular-magician commented Sep 20, 2022

modular-magician commented Sep 22, 2022

modular-magician commented Sep 22, 2022

modular-magician commented Sep 22, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

rileykarson left a comment

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

modular-magician commented Nov 15, 2022

rileykarson left a comment

daveavi commented Nov 18, 2022

Adding Eventarc GoogleChannelConfig Resource support for TPG #6534

Adding Eventarc GoogleChannelConfig Resource support for TPG #6534

Conversation

daveavi commented Sep 10, 2022 • edited by rileykarson

modular-magician commented Sep 10, 2022

Diff report:

modular-magician commented Sep 10, 2022

Tests analytics

Action taken

modular-magician commented Sep 10, 2022

rileykarson commented Sep 13, 2022

modular-magician commented Sep 13, 2022

Diff report:

modular-magician commented Sep 13, 2022

Tests analytics

Action taken

modular-magician commented Sep 14, 2022

modular-magician commented Sep 19, 2022

Diff report:

modular-magician commented Sep 19, 2022

Tests analytics

Action taken

modular-magician commented Sep 19, 2022

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Sep 19, 2022

Diff report:

modular-magician commented Sep 20, 2022

Tests analytics

Action taken

modular-magician commented Sep 20, 2022

modular-magician commented Sep 22, 2022

Diff report:

modular-magician commented Sep 22, 2022

Tests analytics

Action taken

modular-magician commented Sep 22, 2022

modular-magician commented Sep 27, 2022

Diff report:

modular-magician commented Sep 27, 2022

Tests analytics

Action taken

modular-magician commented Sep 27, 2022

modular-magician commented Nov 7, 2022

Diff report

modular-magician commented Nov 7, 2022

Tests analytics

Action taken

modular-magician commented Nov 7, 2022

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 15, 2022

Diff report

modular-magician commented Nov 15, 2022

Tests analytics

Action taken

modular-magician commented Nov 15, 2022

rileykarson left a comment

Choose a reason for hiding this comment

daveavi commented Nov 18, 2022

daveavi commented Sep 10, 2022 •

edited by rileykarson