avro_options added along with test #6557

sanghaniJ · 2022-09-16T08:52:21Z

fixes hashicorp/terraform-provider-google#10119

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: added `avro_options` field to `google_bigquery_table` resource

modular-magician · 2022-09-16T08:53:15Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-09-16T09:03:30Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 125 insertions(+))
Terraform Beta: Diff ( 4 files changed, 125 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-16T09:54:26Z

Tests analytics

Total tests: 2174
Passed tests 1930
Skipped tests: 238
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccStorageTransferJob_transferOptions|TestAccComputeInstance_soleTenantNodeAffinities|TestAccBigQueryTable_AvroPartitioning|TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-16T09:59:44Z

Tests passed during RECORDING mode:
TestAccStorageTransferJob_transferOptions[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccBigQueryTable_AvroPartitioning[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-16T10:16:38Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 125 insertions(+))
Terraform Beta: Diff ( 4 files changed, 125 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-16T11:22:00Z

Tests analytics

Total tests: 2174
Passed tests 1932
Skipped tests: 238
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccBigQueryTable_AvroPartitioning

modular-magician · 2022-09-16T11:27:22Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccBigQueryTable_AvroPartitioning[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-19T06:52:25Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 126 insertions(+))
Terraform Beta: Diff ( 4 files changed, 126 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-19T07:58:26Z

Tests analytics

Total tests: 2175
Passed tests 1933
Skipped tests: 238
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccIapTunnelIamPolicyGenerated

modular-magician · 2022-09-19T08:03:52Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccIapTunnelIamPolicyGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

megan07

Thank you! Very good, just small changes. Thanks!

megan07 · 2022-09-27T17:45:59Z

mmv1/third_party/terraform/resources/resource_bigquery_table.go

+										Type:        schema.TypeBool,
+										Optional:    true,
+										Description: `If sourceFormat is set to "AVRO", indicates whether to interpret logical types as the corresponding BigQuery data type (for example, TIMESTAMP), instead of using the raw type (for example, INTEGER).`,
+										AtLeastOneOf: []string{


We should actually make this required as there are no other options to be set in this block. If someone sets the avro_options block, we need a value set inside of it - and this is the only option right now.

I was going to do the same but as in the API documentation it was mentioned optional, I did the same but in different manner, but adding Required is a better way. So I've made the suggested changes.

megan07 · 2022-09-27T17:48:49Z

mmv1/third_party/terraform/tests/resource_bigquery_table_test.go

+    source_uris= ["gs://${google_storage_bucket.test.name}/*"]
+
+    avro_options {
+		use_avro_logical_types = true


nit: the spacing seems to be inconsistent here

modular-magician · 2022-09-28T06:14:25Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 123 insertions(+))
Terraform Beta: Diff ( 4 files changed, 123 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-28T07:21:33Z

Tests analytics

Total tests: 2184
Passed tests 1941
Skipped tests: 239
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccStorageTransferJob_transferOptions

modular-magician · 2022-09-28T07:26:53Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccStorageTransferJob_transferOptions[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

megan07

Looks good to me! Thanks!

avro_options added along with test

7ceef69

modular-magician requested a review from megan07 September 16, 2022 08:53

avro test file changed

caf8434

markdown file updated

d328064

sanghaniJ marked this pull request as ready for review September 19, 2022 08:32

megan07 suggested changes Sep 27, 2022

View reviewed changes

Suggested Changes in Spacing and Field Required

8109c89

modular-magician requested a review from megan07 September 28, 2022 06:03

megan07 approved these changes Oct 10, 2022

View reviewed changes

megan07 merged commit 6efd53f into GoogleCloudPlatform:main Oct 10, 2022

This was referenced Oct 10, 2022

avro_options added along with test hashicorp/terraform-provider-google-beta#4768

Merged

avro_options added along with test hashicorp/terraform-provider-google#12750

Merged

avro_options added along with test GoogleCloudPlatform/terraform-validator#1037

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

avro_options added along with test #6557

avro_options added along with test #6557

sanghaniJ commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 19, 2022

modular-magician commented Sep 19, 2022

modular-magician commented Sep 19, 2022

megan07 left a comment

megan07 Sep 27, 2022

sanghaniJ Sep 28, 2022

megan07 Sep 27, 2022

modular-magician commented Sep 28, 2022

modular-magician commented Sep 28, 2022

modular-magician commented Sep 28, 2022

megan07 left a comment

avro_options added along with test #6557

avro_options added along with test #6557

Conversation

sanghaniJ commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

Diff report:

modular-magician commented Sep 16, 2022

Tests analytics

Action taken

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

Diff report:

modular-magician commented Sep 16, 2022

Tests analytics

Action taken

modular-magician commented Sep 16, 2022

modular-magician commented Sep 19, 2022

Diff report:

modular-magician commented Sep 19, 2022

Tests analytics

Action taken

modular-magician commented Sep 19, 2022

megan07 left a comment

Choose a reason for hiding this comment

megan07 Sep 27, 2022

Choose a reason for hiding this comment

sanghaniJ Sep 28, 2022

Choose a reason for hiding this comment

megan07 Sep 27, 2022

Choose a reason for hiding this comment

modular-magician commented Sep 28, 2022

Diff report:

modular-magician commented Sep 28, 2022

Tests analytics

Action taken

modular-magician commented Sep 28, 2022

megan07 left a comment

Choose a reason for hiding this comment