upgraded dcl

[avinash84]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: machine_type field in compute instance resource now accepts short name.

orgpolicy: Changed spec.rules type from Array to Set in policy resource.
https://github.com/hashicorp/terraform-provider-google/issues/12363

clouddeploy: Added serial_pipeline.stages.strategy in delivery_pipeline resource.
clouddeploy: Added execution_configs.execution_timeout in target resource.
clouddeploy: Added support for cloud run fields as dependency in target resource.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:
*

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 230 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 10 files changed, 230 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2192
Passed tests 1904
Skipped tests: 240
Failed tests: 48

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccDataSourceGoogleGlobalForwardingRule|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccDataSourceGoogleForwardingRule|TestAccComputeRouterInterface_withTunnel|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccClouddeployTarget_Target|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyAssociation_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log]
TestAccComputeVpnTunnel_regionFromGateway[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeGlobalForwardingRule_ipv6[Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeFirewallPolicyAssociation_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[c2thorn]

Hi @avinash84
I'm not seeing the same changes that are mentioned in the release notes. From https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-6614-old..auto-pr-6614, it is showing changes to two clouddeploy resources and eventarc trigger.

Additionally, there is a org_policy_policy change that sets a field from a List->Set which is a breaking change, which we will not be able to merge in a minor release. Do you know why that change is included?

[c2thorn]

Unintentionally approved, see previous message

[Darien-Lin]

There has been a recent change to release track for Clouddeploy, moving things exposed from GA to beta. Would it be possible for you to use DCL: v1.23.0 instead of v1.22.1?

[alphanota]

Hello, would you consider reviewing and merging #6639 instead of this PR? #6639 contains fixes to the execution timeout field that this PR already has, as well as the move from GA to beta track taht @Darien-Lin mentioned. Thanks!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 230 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 10 files changed, 230 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2184
Passed tests 1900
Skipped tests: 239
Failed tests: 45

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccDataSourceGoogleGlobalForwardingRule|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeRouterPeer_basic|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRoute_routeIlbExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeVpnTunnel_router|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeRouterPeer_advertiseMode|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccClouddeployTarget_Target|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_labels|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_update|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleForwardingRule|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicy_update

[avinash84]

Discarding this PR. Published some fixes in new release.

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceGoogleGlobalForwardingRule[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeGlobalForwardingRule_updateTarget[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceGoogleForwardingRule[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccClouddeployTarget_Target[Error message] [Debug log]
TestAccOrgPolicyPolicy_FolderPolicy[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test