Add AppleApp to Firebase. #6630

mraouffouad · 2022-09-30T16:40:40Z

Add AppleApp resource to Firebase.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2022-09-30T16:41:39Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-09-30T16:52:49Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 127 insertions(+))
Terraform Beta: Diff ( 4 files changed, 565 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-30T17:37:35Z

Tests analytics

Total tests: 2194
Passed tests 1951
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccFirebaseAppleApp_firebaseAppleAppBasicExample|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-30T17:39:25Z

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/products/firebase/api.yaml

mmv1/products/firebase/terraform.yaml

mmv1/templates/terraform/examples/firebase_apple_app_basic.tf.erb

tylerg-dev · 2022-09-30T18:46:29Z

mmv1/templates/terraform/examples/firebase_apple_app_basic.tf.erb

+	project  = google_project.default.project_id
+}
+
+resource "google_firebase_apple_app" "<%= ctx[:primary_resource_id] %>" {


I think we likely want to have 2 samples in general:

a minimal sample that sets only the minimally required fields

a full sample that sets all optional values with example values

+1 - please also add an update test.

mmv1/products/firebase/terraform.yaml

mmv1/templates/terraform/examples/firebase_apple_app_basic.tf.erb

modular-magician · 2022-10-05T04:41:38Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 115 insertions(+))
Terraform Beta: Diff ( 4 files changed, 627 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-05T05:18:40Z

Tests analytics

Total tests: 2201
Passed tests 1956
Skipped tests: 240
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseAppleApp_firebaseAppleAppBasicExample|TestAccComputeForwardingRule_update|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-05T05:23:59Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…le test

modular-magician · 2022-10-05T18:45:06Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 115 insertions(+))
Terraform Beta: Diff ( 4 files changed, 629 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

mmv1/products/firebase/terraform.yaml

modular-magician · 2022-10-05T19:33:36Z

Tests analytics

Total tests: 2208
Passed tests 1962
Skipped tests: 240
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaseAppleApp_firebaseAppleAppBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigQueryDataTable_bigtable

modular-magician · 2022-10-05T19:38:54Z

Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-09T00:59:31Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 231 insertions(+))
Terraform Beta: Diff ( 5 files changed, 745 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-09T01:40:23Z

Tests analytics

Total tests: 2208
Passed tests 1965
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaseAppleApp_firebaseAppleAppBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-09T01:45:30Z

Tests failed during RECORDING mode:
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-09T14:47:32Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 231 insertions(+))
Terraform Beta: Diff ( 5 files changed, 745 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-09T15:31:17Z

Tests analytics

Total tests: 2208
Passed tests 1965
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaseAppleApp_firebaseAppleAppBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-09T15:33:09Z

Tests failed during RECORDING mode:
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath

looking really good! Just a few minor cleanups noted below

mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb

mmv1/products/firebase/terraform.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

…pdate_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

mraouffouad · 2022-11-11T20:16:25Z

looking really good! Just a few minor cleanups noted below

Thanks Stephen for the suggestions. All is done. My only concern is that I'm not sure if removing the test_vars_overrides section will pass the tests. As I mentioned before team_id and app_store_id are integers and moving them to the vars section will append their set values by random string in the test, and therefore fail our API validators. I tried this a few times before and always got "Error: Error creating AppleApp: googleapi: Error 400: Request contains an invalid argument". I decided to give it one more try and let's see how the tests go.

modular-magician · 2022-11-11T20:20:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 254 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 12 files changed, 879 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-11T21:05:57Z

Tests analytics

Total tests: 2246
Passed tests 2001
Skipped tests: 241
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseAppleApp_update|TestAccFirebaseAppleApp_firebaseAppleAppBasicExample|TestAccFirebaseAppleApp_firebaseAppleAppFullExample

modular-magician · 2022-11-11T21:06:34Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccFirebaseAppleApp_update[Debug log]
TestAccFirebaseAppleApp_firebaseAppleAppBasicExample[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseAppleApp_firebaseAppleAppFullExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mraouffouad · 2022-11-11T21:09:34Z

looking really good! Just a few minor cleanups noted below

Thanks Stephen for the suggestions. All is done. My only concern is that I'm not sure if removing the test_vars_overrides section will pass the tests. As I mentioned before team_id and app_store_id are integers and moving them to the vars section will append their set values by random string in the test, and therefore fail our API validators. I tried this a few times before and always got "Error: Error creating AppleApp: googleapi: Error 400: Request contains an invalid argument". I decided to give it one more try and let's see how the tests go.

As expected, test failed because of the added random suffixes to these 2 variables.

{
"appStoreId": "12345rnoosq6yng",
"bundleId": "apple.app.12345rnoosq6yng",
"displayName": "Display Name Fullrnoosq6yng",
"teamId": "9987654321rnoosq6yng"
}

2022/11/11 21:06:06 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 400 Bad Request
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Fri, 11 Nov 2022 21:06:06 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
"error": {
"code": 400,
"message": "Request contains an invalid argument.",
"status": "INVALID_ARGUMENT"
}
}

modular-magician · 2022-11-11T21:28:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 254 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 12 files changed, 881 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-11T22:19:43Z

Tests analytics

Total tests: 2247
Passed tests 2004
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaseAppleApp_firebaseAppleAppFullExample|TestAccComputeForwardingRule_update

modular-magician · 2022-11-11T22:21:04Z

Tests passed during RECORDING mode:
TestAccFirebaseAppleApp_firebaseAppleAppFullExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

mraouffouad · 2022-11-15T04:30:09Z

@melinath is there anything blocking this PR at this point?

melinath · 2022-11-15T19:54:04Z

LGTM - doing a manual test run just to be safe: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/353024

stale review

* Update api.yaml * Update api.yaml * Update api.yaml * Update api.yaml * Update terraform.yaml * Create firebase_apple_app_basic.tf.erb * Responding to tylerg-dev's comments * Fixing the failing TestAccFirebaseAppleApp_firebaseAppleAppBasicExample test * Add a handwritten sweeper to hard-delete the AppleApp * Fix typo in update_mask * Fix var name in test * Add delete request body * Change appId to app_id in the sweeper delete url * Use custom_delete for deleting the AppleApp resource * Update api.yaml * Remove the repeated block in terraform.api * Add a 5 sec in the post_delete template * Move the 5 sec delay to the custom delete code * Add "Optional" to the deletion_policy description. * Address melinath@ comments * Add a manual update test * Remove unnecessary randomness. Also, move attributes to the vars section so they show up in docs. * Update mmv1/products/firebase/terraform.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/firebase/terraform.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/firebase/terraform.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_update_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Adding back the test_vars_overrides. Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

mraouffouad added 6 commits September 28, 2022 15:00

Update api.yaml

cd2e519

Update api.yaml

1b15c11

Update api.yaml

165fe20

Update api.yaml

e8e5952

Update terraform.yaml

7e4c7b6

Create firebase_apple_app_basic.tf.erb

ddf4945

modular-magician requested a review from megan07 September 30, 2022 16:41

tylerg-dev reviewed Sep 30, 2022

View reviewed changes

Responding to tylerg-dev's comments

aa06508

Fixing the failing TestAccFirebaseAppleApp_firebaseAppleAppBasicExamp…

b4bdab7

…le test

tylerg-dev reviewed Oct 5, 2022

View reviewed changes

mmv1/products/firebase/terraform.yaml Show resolved Hide resolved

mraouffouad added 2 commits October 8, 2022 20:36

Add a handwritten sweeper to hard-delete the AppleApp

538088e

Fix typo in update_mask

34d6a94

Fix var name in test

5810834

melinath requested changes Nov 11, 2022

View reviewed changes

mraouffouad and others added 2 commits November 11, 2022 15:02

Update mmv1/products/firebase/terraform.yaml

001787e

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update mmv1/products/firebase/terraform.yaml

7f47475

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

modular-magician requested a review from melinath November 11, 2022 20:03

mraouffouad and others added 4 commits November 11, 2022 15:05

Update mmv1/products/firebase/terraform.yaml

6bce9c0

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_u…

c9ca82e

…pdate_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_u…

387eaff

…pdate_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_u…

7dcb89a

…pdate_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Adding back the test_vars_overrides.

5b5ba72

melinath approved these changes Nov 15, 2022

View reviewed changes

melinath merged commit 2fecbdf into GoogleCloudPlatform:main Nov 15, 2022

This was referenced Nov 15, 2022

Add AppleApp to Firebase. hashicorp/terraform-provider-google-beta#4887

Merged

Add AppleApp to Firebase. hashicorp/terraform-provider-google#13047

Merged

Add AppleApp to Firebase. GoogleCloudPlatform/terraform-validator#1124

Merged

mraouffouad mentioned this pull request Dec 2, 2022

Add Firebase AppleApp Data Source #6876

Merged

5 tasks

AlfatahB mentioned this pull request Dec 22, 2022

Add support for managing Firebase iOS apps hashicorp/terraform-provider-google#6520

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AppleApp to Firebase. #6630

Add AppleApp to Firebase. #6630

mraouffouad commented Sep 30, 2022

modular-magician commented Sep 30, 2022

modular-magician commented Sep 30, 2022

modular-magician commented Sep 30, 2022

modular-magician commented Sep 30, 2022

tylerg-dev Sep 30, 2022

melinath Nov 7, 2022

modular-magician commented Oct 5, 2022

modular-magician commented Oct 5, 2022

modular-magician commented Oct 5, 2022

modular-magician commented Oct 5, 2022

modular-magician commented Oct 5, 2022

modular-magician commented Oct 5, 2022

modular-magician commented Oct 9, 2022

modular-magician commented Oct 9, 2022

modular-magician commented Oct 9, 2022

modular-magician commented Oct 9, 2022

modular-magician commented Oct 9, 2022

modular-magician commented Oct 9, 2022

melinath left a comment

mraouffouad commented Nov 11, 2022 •

edited

modular-magician commented Nov 11, 2022

modular-magician commented Nov 11, 2022

modular-magician commented Nov 11, 2022

mraouffouad commented Nov 11, 2022

modular-magician commented Nov 11, 2022

modular-magician commented Nov 11, 2022

modular-magician commented Nov 11, 2022

mraouffouad commented Nov 15, 2022

melinath commented Nov 15, 2022

Add AppleApp to Firebase. #6630

Add AppleApp to Firebase. #6630

Conversation

mraouffouad commented Sep 30, 2022

modular-magician commented Sep 30, 2022

modular-magician commented Sep 30, 2022

Diff report:

modular-magician commented Sep 30, 2022

Tests analytics

Action taken

modular-magician commented Sep 30, 2022

tylerg-dev Sep 30, 2022

Choose a reason for hiding this comment

melinath Nov 7, 2022

Choose a reason for hiding this comment

modular-magician commented Oct 5, 2022

Diff report:

modular-magician commented Oct 5, 2022

Tests analytics

Action taken

modular-magician commented Oct 5, 2022

modular-magician commented Oct 5, 2022

Diff report:

modular-magician commented Oct 5, 2022

Tests analytics

Action taken

modular-magician commented Oct 5, 2022

modular-magician commented Oct 9, 2022

Diff report:

modular-magician commented Oct 9, 2022

Tests analytics

Action taken

modular-magician commented Oct 9, 2022

modular-magician commented Oct 9, 2022

Diff report:

modular-magician commented Oct 9, 2022

Tests analytics

Action taken

modular-magician commented Oct 9, 2022

melinath left a comment

Choose a reason for hiding this comment

mraouffouad commented Nov 11, 2022 • edited

modular-magician commented Nov 11, 2022

Diff report

modular-magician commented Nov 11, 2022

Tests analytics

Action taken

modular-magician commented Nov 11, 2022

mraouffouad commented Nov 11, 2022

modular-magician commented Nov 11, 2022

Diff report

modular-magician commented Nov 11, 2022

Tests analytics

Action taken

modular-magician commented Nov 11, 2022

mraouffouad commented Nov 15, 2022

melinath commented Nov 15, 2022

mraouffouad commented Nov 11, 2022 •

edited