Added requested attributes in google_container_cluster resource

[mitj04]

fixes hashicorp/terraform-provider-google#9180

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Added min_cpu_platform, management, and shielded_instance_config attributes to the google_container_cluster resource

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've sorted out the following information about your changes, here it is - !

Diff report

Terraform GA: Diff ( 3 files changed, 1966 insertions(+), 1147 deletions(-))
Terraform Beta: Diff ( 3 files changed, 1916 insertions(+), 1182 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've sorted out the following information about your changes, here it is - !

Diff report

Terraform GA: Diff ( 3 files changed, 1966 insertions(+), 1147 deletions(-))
Terraform Beta: Diff ( 3 files changed, 1916 insertions(+), 1182 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've sorted out the following information about your changes, here it is - !

Diff report

Terraform GA: Diff ( 3 files changed, 823 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 773 insertions(+), 39 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've sorted out the following information about your changes, here it is - !

Diff report

Terraform GA: Diff ( 3 files changed, 826 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 776 insertions(+), 39 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 829 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 779 insertions(+), 39 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 829 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 779 insertions(+), 39 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

[modular-magician]

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 836 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 786 insertions(+), 39 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2204
Passed tests 1952
Skipped tests: 240
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_autoprovisioningDefaultsManagement|TestAccContainerCluster_autoprovisioningDefaultsDiskType|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_nodeAutoprovisioning|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_autoprovisioningDefaultsShieldedInstanceConfig|TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings|TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccContainerCluster_autoprovisioningDefaultsManagement[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsDiskType[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults[Debug log]
TestAccContainerCluster_nodeAutoprovisioning[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsShieldedInstanceConfig[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[mitj04]

@rileykarson, Could you please review this PR?

[rileykarson]

Sorry, this is a large PR and I haven't found the cycles to sit down and work through a first pass. One thing you could consider is splitting it up- smaller PRs tend to be easier to address.

Also, one thing to watch out for is other outstanding PRs like https://github.com/GoogleCloudPlatform/magic-modules/pull/6618/files which I think add some of the same fields.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 676 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 626 insertions(+), 41 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 684 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 3 files changed, 634 insertions(+), 49 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2212
Passed tests 1962
Skipped tests: 239
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_withNodeConfigReservationAffinitySpecific|TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccBigQueryDataTable_bigtable

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]

Tests failed during RECORDING mode:
TestAccContainerCluster_withNodePoolNodeConfig[Error message] [Debug log]
TestAccContainerCluster_withSoleTenantGroup[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinitySpecific[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinity[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigShieldedInstanceConfig[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigScopeAlias[Error message] [Debug log]
TestAccContainerCluster_withNodeConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 677 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 627 insertions(+), 42 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2212
Passed tests 1972
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_withNodeConfig

[modular-magician]

Tests failed during RECORDING mode:
TestAccContainerCluster_withNodeConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 676 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 626 insertions(+), 41 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2212
Passed tests 1972
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 372 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 322 insertions(+), 41 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2214
Passed tests 1965
Skipped tests: 239
Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccContainerCluster_autoprovisioningDefaultsShieldedInstanceConfig|TestAccContainerCluster_autoprovisioningDefaultsManagement|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_nodeAutoprovisioning|TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsShieldedInstanceConfig[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsManagement[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults[Debug log]
TestAccContainerCluster_nodeAutoprovisioning[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[mitj04]

Sorry, this is a large PR and I haven't found the cycles to sit down and work through a first pass. One thing you could consider is splitting it up- smaller PRs tend to be easier to address.

Also, one thing to watch out for is other outstanding PRs like https://github.com/GoogleCloudPlatform/magic-modules/pull/6618/files which I think add some of the same fields.

Hi @rileykarson, I've split the PR and kept management and shielded_instance_config attributes for this PR. In other PR(#6764), I've kept the upgrade_setting attribute only. Once you will review this PR, I will mark that PR for review as its TCs are failing due to Quota 'FIREWALLS' exceeded.

[mitj04]

I'm closing this PR as another PR with the same attribute has been added. For now just to avoid any confusion/mistakes and excessive commits, raising a new PR for upgrade_settings and min_cpu_platform(#6771) attributes. Once this PR will merge, I will raise a separate PR for the management.