Adding data source support for google_compute_region_network_endpoint_group #6663

googlerjk · 2022-10-06T21:32:10Z

Adding support for data source to google_compute_region_network_endpoint_group resource

fixes hashicorp/terraform-provider-google#10989

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

 `google_compute_region_network_endpoint_group`

modular-magician · 2022-10-06T21:33:06Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-10-06T21:44:27Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 146 insertions(+))
Terraform Beta: Diff ( 4 files changed, 146 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-06T22:22:16Z

Tests analytics

Total tests: 2207
Passed tests 1963
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccFirebaserulesRelease_BasicRelease|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-06T22:24:12Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-07T21:32:36Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 144 insertions(+))
Terraform Beta: Diff ( 4 files changed, 144 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-07T22:18:49Z

Tests analytics

Total tests: 2208
Passed tests 1963
Skipped tests: 240
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccStorageObjectAcl_basic|TestAccDataSourceRegionNetworkEndpointGroup

modular-magician · 2022-10-07T22:24:40Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccStorageObjectAcl_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccDataSourceRegionNetworkEndpointGroup[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-07T23:36:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 139 insertions(+))
Terraform Beta: Diff ( 4 files changed, 139 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-08T00:25:18Z

Tests analytics

Total tests: 2208
Passed tests 1964
Skipped tests: 240
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccDataSourceRegionNetworkEndpointGroup|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-08T00:30:39Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccDataSourceRegionNetworkEndpointGroup[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn

The test is failing with


    testing_new_config.go:79: no "id" found in attributes
    testing_new.go:62: no "id" found in attributes

c2thorn · 2022-10-10T16:23:25Z

...third_party/terraform/tests/data_source_google_compute_region_network_endpoint_group_test.go

+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TestAccDataSourceRegionNetworkEndpointGroup(t *testing.T) {


Suggested change

func TestAccDataSourceRegionNetworkEndpointGroup(t *testing.T) {

func TestAccDataSourceRegionNetworkEndpointGroup_basic(t *testing.T) {

c2thorn · 2022-10-10T16:24:52Z

mmv1/third_party/terraform/utils/provider.go.erb

 			"google_compute_regions":                           dataSourceGoogleComputeRegions(),
+			"google_compute_region_network_endpoint_group":		dataSourceGoogleComputeRegionNetworkEndpointGroup(),


you have tabs between the datasource name and method where other lines have spaces

modular-magician · 2022-10-10T20:32:07Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 139 insertions(+))
Terraform Beta: Diff ( 4 files changed, 139 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-10T21:12:08Z

Tests analytics

Total tests: 2209
Passed tests 1963
Skipped tests: 240
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccDataSourceRegionNetworkEndpointGroup_basic

modular-magician · 2022-10-10T21:39:12Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccDataSourceRegionNetworkEndpointGroup_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-11T09:22:42Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 128 insertions(+))
Terraform Beta: Diff ( 4 files changed, 128 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-11T10:08:59Z

Tests analytics

Total tests: 2216
Passed tests 1973
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccDataSourceRegionNetworkEndpointGroup_basic|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-10-11T10:14:53Z

Tests passed during RECORDING mode:
TestAccDataSourceRegionNetworkEndpointGroup_basic[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-11T21:47:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 127 insertions(+))
Terraform Beta: Diff ( 4 files changed, 127 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-11T22:26:44Z

Tests analytics

Total tests: 2217
Passed tests 1976
Skipped tests: 240
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities

modular-magician · 2022-10-11T22:28:42Z

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn · 2022-10-12T13:33:49Z

/gcbrun

c2thorn · 2022-10-12T14:19:01Z

/gcbrun

c2thorn · 2022-10-12T14:21:39Z

/gcbrun

c2thorn · 2022-10-12T14:38:28Z

/gcbrun

c2thorn · 2022-10-12T14:43:21Z

/gcbrun

modular-magician · 2022-10-12T14:57:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 127 insertions(+))
Terraform Beta: Diff ( 4 files changed, 127 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-12T15:45:06Z

Tests analytics

Total tests: 2193
Passed tests 1953
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities

modular-magician · 2022-10-12T15:47:34Z

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn

still needs documentation

modular-magician · 2022-10-12T22:21:04Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 179 insertions(+))
Terraform Beta: Diff ( 5 files changed, 179 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-12T23:06:55Z

Tests analytics

Total tests: 2198
Passed tests 1958
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-10-12T23:07:16Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

c2thorn

Can be merged after you link the appropriate issue in the main comment

modular-magician · 2022-10-18T22:06:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 176 insertions(+))
Terraform Beta: Diff ( 5 files changed, 176 insertions(+))
TF Validator: Diff ( 3 files changed, 7 insertions(+), 3 deletions(-))

modular-magician · 2022-10-18T22:45:20Z

Tests analytics

Total tests: 2195
Passed tests 1955
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-10-18T22:45:44Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

initial files and code updates

f1dbe89

modular-magician requested a review from shuyama1 October 6, 2022 21:33

googlerjk requested a review from c2thorn October 6, 2022 21:35

googlerjk removed the request for review from shuyama1 October 7, 2022 19:44

googlerjk added 2 commits October 7, 2022 21:11

test file format update

fd72118

datasource name and format update

5f98b04

googlerjk requested a review from shuyama1 October 7, 2022 22:26

c2thorn removed the request for review from shuyama1 October 10, 2022 16:18

c2thorn requested changes Oct 10, 2022

View reviewed changes

googlerjk force-pushed the jk-datasoure-for-rneg branch from 8d127f4 to fda5a71 Compare October 10, 2022 20:18

modular-magician requested a review from c2thorn October 10, 2022 20:19

googlerjk added 2 commits October 11, 2022 04:12

updated required fields and full datasource field check in test

5fc1ab6

changes to tests for minimal basic requirements

c0d1f83

googlerjk force-pushed the jk-datasoure-for-rneg branch from fda5a71 to c0d1f83 Compare October 11, 2022 09:07

c2thorn approved these changes Oct 12, 2022

View reviewed changes

c2thorn requested changes Oct 12, 2022

View reviewed changes

documentation added

13c77ef

modular-magician requested a review from c2thorn October 12, 2022 22:08

c2thorn approved these changes Oct 13, 2022

View reviewed changes

c2thorn changed the title ~~Adding data source support for google_compute_region_network_endpoint_group #6606~~ Adding data source support for google_compute_region_network_endpoint_group Oct 13, 2022

updated markdown

19b61ca

modular-magician requested a review from c2thorn October 18, 2022 21:53

c2thorn approved these changes Oct 20, 2022

View reviewed changes

c2thorn merged commit 07fb636 into GoogleCloudPlatform:main Oct 20, 2022

	func TestAccDataSourceRegionNetworkEndpointGroup(t *testing.T) {
	func TestAccDataSourceRegionNetworkEndpointGroup_basic(t *testing.T) {

		"google_compute_regions": dataSourceGoogleComputeRegions(),
		"google_compute_region_network_endpoint_group": dataSourceGoogleComputeRegionNetworkEndpointGroup(),

Adding data source support for google_compute_region_network_endpoint_group #6663

Adding data source support for google_compute_region_network_endpoint_group #6663

Conversation

googlerjk commented Oct 6, 2022 • edited

modular-magician commented Oct 6, 2022

modular-magician commented Oct 6, 2022

Diff report:

modular-magician commented Oct 6, 2022

Tests analytics

Action taken

modular-magician commented Oct 6, 2022

modular-magician commented Oct 7, 2022

Diff report:

modular-magician commented Oct 7, 2022

Tests analytics

Action taken

modular-magician commented Oct 7, 2022

modular-magician commented Oct 7, 2022

Diff report:

modular-magician commented Oct 8, 2022

Tests analytics

Action taken

modular-magician commented Oct 8, 2022

c2thorn left a comment

Choose a reason for hiding this comment

c2thorn Oct 10, 2022

Choose a reason for hiding this comment

c2thorn Oct 10, 2022

Choose a reason for hiding this comment

modular-magician commented Oct 10, 2022

Diff report:

modular-magician commented Oct 10, 2022

Tests analytics

Action taken

modular-magician commented Oct 10, 2022

modular-magician commented Oct 11, 2022

Diff report:

modular-magician commented Oct 11, 2022

Tests analytics

Action taken

modular-magician commented Oct 11, 2022

modular-magician commented Oct 11, 2022

Diff report:

modular-magician commented Oct 11, 2022

Tests analytics

Action taken

modular-magician commented Oct 11, 2022

c2thorn commented Oct 12, 2022

c2thorn commented Oct 12, 2022

c2thorn commented Oct 12, 2022

c2thorn commented Oct 12, 2022

c2thorn commented Oct 12, 2022

modular-magician commented Oct 12, 2022

Diff report:

modular-magician commented Oct 12, 2022

Tests analytics

Action taken

modular-magician commented Oct 12, 2022

c2thorn left a comment

Choose a reason for hiding this comment

modular-magician commented Oct 12, 2022

Diff report:

modular-magician commented Oct 12, 2022

Tests analytics

Action taken

modular-magician commented Oct 12, 2022

c2thorn left a comment

Choose a reason for hiding this comment

modular-magician commented Oct 18, 2022

Diff report:

modular-magician commented Oct 18, 2022

Tests analytics

Action taken

modular-magician commented Oct 18, 2022

googlerjk commented Oct 6, 2022 •

edited