connectorEnforcement field added along with modified test

[sanghaniJ]

connector_enforcement field added to sql_database_instance resource
settings test case modified with new field

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudsql: added `connector_enforcement` field to `google_sql_database_instance` resource

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[ScottSuarez]

Could you try pulling in the latest changes from main? We recently made a CI change which may be causing failures

[ScottSuarez]

I notice this pr is in draft. Let me know when it's ready for review

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 11 insertions(+))
Terraform Beta: Diff ( 3 files changed, 11 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2197
Passed tests 1945
Skipped tests: 239
Failed tests: 13

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccSqlDatabaseInstance_Timezone|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_maintenanceVersion|TestAccSqlDatabaseInstance_basicMSSQL|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_settings_secondary[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Error message] [Debug log]
TestAccSqlDatabaseInstance_Timezone[Error message] [Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels[Error message] [Debug log]
TestAccSqlDatabaseInstance_authNets[Error message] [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade[Error message] [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection[Error message] [Debug log]
TestAccSqlDatabaseInstance_maintenanceVersion[Error message] [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 12 insertions(+))
Terraform Beta: Diff ( 3 files changed, 12 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2186
Passed tests 1938
Skipped tests: 239
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_basicMSSQL

[modular-magician]

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_settings_deletionProtection[Debug log]
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels[Debug log]
TestAccSqlDatabaseInstance_authNets[Debug log]
TestAccSqlDatabaseInstance_settings_upgrade[Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled[Debug log]
TestAccSqlDatabaseInstance_basicMSSQL[Debug log]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[sanghaniJ]

@ScottSuarez There are 2 tests failing for the resource but it doesn't seem like that is happening due to the field I've added. Those tests are failing in the current version as well. How do I proceed now?

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 12 insertions(+))
Terraform Beta: Diff ( 3 files changed, 12 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2186
Passed tests 1943
Skipped tests: 239
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[ScottSuarez]

Hi Jay, would you be able to file a bug with the team that owns the api failing in the test. It's not clear to me why it's failing and claims to be transient. According to our reruns. This claim is not holding up

[sanghaniJ]

Actually I'm not authorised to do so, hence if possible can you do that on my behalf.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 12 insertions(+))
Terraform Beta: Diff ( 3 files changed, 12 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2196
Passed tests 1955
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_SqlServerAuditConfig

[modular-magician]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[melinath]

"transient error" should now be resolved /gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 12 insertions(+))
Terraform Beta: Diff ( 3 files changed, 12 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 14 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 14 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1967
Skipped tests: 239
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeForwardingRule_update|TestAccSqlDatabaseInstance_settings_secondary|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccSqlDatabaseInstance_settings_secondary[Debug log]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[ScottSuarez]

Lets skip_vcr on the following tests to unblock this change.

TestAccSqlDatabaseInstance_SqlServerAuditConfig
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

These tests are failing in teamcity (our nightly runs). Could you also create a bug to track that we disabled them?
https://github.com/hashicorp/terraform-provider-google/issues/new?assignees=&labels=test+failure&template=10_test_failure.md&title=Failing+test%28s%29%3A+TestAccWhatever

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 18 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 18 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2213
Passed tests 1972
Skipped tests: 240
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 16 insertions(+))
Terraform Beta: Diff ( 3 files changed, 16 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2213
Passed tests 1971
Skipped tests: 241
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[sanghaniJ]

@ScottSuarez I've added skipVcr and now the checks are passing. About the failing tests, I guess Stephen has created a bug ticket for the failing 2 tests along with some other tests.

[sanghaniJ]

Also, there are several test cases with Failure due to the same issue, they were already added to SkipVcr.

[ScottSuarez]

Have you been able to run these tests locally and do they pass for you.

I am curious if we can get a minimum config test passing. Without some sort of knowledge as to, yes I can confirm this works. I worry about merging. I could also perhaps try to run some tests locally.

[sanghaniJ]

I guess it has a similar issue for all such test cases, regarding the Service Networking which results into failure. I've tried running locally but the tests are failing.

[sanghaniJ]

Hi @ScottSuarez, Can you have a look. What I found was all the cases with Service Networking present are skipped as of now. Looks like it is blocking several cases. I guess it will be fine to proceed. Also wanted to ask, did you get any findings running it locally?

[ScottSuarez]

Yeah, if we can't get any sort test to pass with this field, locally or otherwise. I'm against merging. If you can produce a configuration and deployment that works I am more comfortable checking this change in.

[sanghaniJ]

Just to be clear, the serviceNetworking field isn't added by me. It is already present and is the reason for the multiple test failures which are failing in TeamCity as well. The field I've added is connectorEnforcement and it is added in the test testGoogleSqlDatabaseInstance_settings_secondary which passes fine.

[ScottSuarez]

Ack, apologies here. It's been so long trying to sort this out the context was lost. Thanks for your patience here.