Made cloud identity groups updatable and updated documentation

[NA2047]

Continuing forward from @melinath PR #5460

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudidentity: for group resource, made security label settable by making labels updatable

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 24 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 24 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2195
Passed tests 1955
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccCloudIdentityGroup_update

[modular-magician]

Tests failed during RECORDING mode:
TestAccCloudIdentityGroup_update[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 24 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 24 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2186
Passed tests 1945
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccCloudIdentityGroup_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccCloudIdentityGroup_update[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 24 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 24 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2186
Passed tests 1946
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccCloudIdentityGroup_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccCloudIdentityGroup_update[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 24 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 24 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2186
Passed tests 1947
Skipped tests: 239
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

[c2thorn]

running a quick test to confirm it is behaving correctly now

[c2thorn]

The test failed, making me think that the API has not updated the functionality correctly.

=== CONT  TestAccCloudIdentityGroup_update
provider_test.go:315: Step 2/2 error: After applying this test step, the plan was not empty.
stdout:
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# google_cloud_identity_group.cloud_identity_group_basic will be updated in-place
~ resource "google_cloud_identity_group" "cloud_identity_group_basic" {
...
~ labels               = {
"cloudidentity.googleapis.com/groups.discussion_forum" = ""
+ "cloudidentity.googleapis.com/groups.security"         = ""
}
...
}
Plan: 0 to add, 1 to change, 0 to destroy.

@NA2047 have you been able to test the update functionality?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 34 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 34 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1960
Skipped tests: 239
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccAccessContextManager|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserWithMemberKey|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipWithMemberKey|TestAccCloudIdentityGroupMembership_import|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserExample|TestAccCloudIdentityGroupMembership_update|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipExample|TestAccCloudIdentityGroup_cloudIdentityGroupsBasicExample|TestAccCloudIdentityGroup_update

[modular-magician]

Tests failed during RECORDING mode:
TestAccDataSourceCloudIdentityGroupMemberships_basic[Error message] [Debug log]
TestAccDataSourceCloudIdentityGroups_basic[Error message] [Debug log]
TestAccAccessContextManager[Error message] [Debug log]
TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserWithMemberKey[Error message] [Debug log]
TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipWithMemberKey[Error message] [Debug log]
TestAccCloudIdentityGroupMembership_import[Error message] [Debug log]
TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserExample[Error message] [Debug log]
TestAccCloudIdentityGroupMembership_update[Error message] [Debug log]
TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipExample[Error message] [Debug log]
TestAccCloudIdentityGroup_cloudIdentityGroupsBasicExample[Error message] [Debug log]
TestAccCloudIdentityGroup_update[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 29 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 29 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1970
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccCloudIdentityGroup_update

[modular-magician]

Tests failed during RECORDING mode:
TestAccCloudIdentityGroup_update[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 29 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 29 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1968
Skipped tests: 239
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccCloudIdentityGroup_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccCloudIdentityGroup_update[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[c2thorn]

The eventual consistency for deletes on this resource in stubborn. The test is failing because of it. I removed the polling for delete since it fails on 403 errors but it looks like there's no getting around it.

Do you mind adding it back in with a new check_response_func_absence function?
We need the absence version of https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/utils/common_polling.go#L122

where we continue polling on 403 errors

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 46 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 46 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2215
Passed tests 1964
Skipped tests: 239
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccAccessContextManager|TestAccFirebaserulesRelease_BasicRelease|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserExample|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipExample|TestAccCloudIdentityGroup_cloudIdentityGroupsBasicExample|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserWithMemberKey|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipWithMemberKey|TestAccCloudIdentityGroup_update|TestAccCloudIdentityGroupMembership_import|TestAccCloudIdentityGroupMembership_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceCloudIdentityGroupMemberships_basic[Debug log]
TestAccDataSourceCloudIdentityGroups_basic[Debug log]
TestAccAccessContextManager[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserExample[Debug log]
TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipExample[Debug log]
TestAccCloudIdentityGroup_cloudIdentityGroupsBasicExample[Debug log]
TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserWithMemberKey[Debug log]
TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipWithMemberKey[Debug log]
TestAccCloudIdentityGroup_update[Debug log]
TestAccCloudIdentityGroupMembership_import[Debug log]
TestAccCloudIdentityGroupMembership_update[Debug log]

All tests passed
View the build log or the debug log for each test