Add support for network_firewall_policy and region_network_firewall_policy #6693

ghabian · 2022-10-13T23:12:27Z

This PR adds support for the network_firewall_policy resource, and its regional counterpart (region_network_firewall_policy). These resources have been integrated into the DCL already and requires DCL v1.25 .

I'm also adding two new fields into meta.yaml: doc_hide_conditional and test_hide_conditional as I have not found a better way to handle samples for primary DCL resources that have regional and global versions such as network_firewall_policy and forwarding_rule. These two new fields will allow the splitting of the samples directory by the location field; selectively hiding certain sample files for certain location fields.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_network_firewall_policy`

`google_compute_region_network_firewall_policy`

… regional and global flavors

google-cla · 2022-10-13T23:12:31Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

…dules into dcl-nfp-promote

modular-magician · 2022-10-14T03:55:58Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 33 files changed, 4483 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 35 files changed, 4992 insertions(+), 157 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

modular-magician · 2022-10-14T05:01:06Z

Tests analytics

Total tests: 2192
Passed tests 1891
Skipped tests: 239
Failed tests: 62

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRegionalNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeVpnTunnel_router|TestAccComputeRegionalNetworkFirewallPolicy_RegionalHandWritten|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeRegionalNetworkFirewallPolicyAssociation_RegionalHandWritten|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeNetworkFirewallPolicy_GlobalHandWritten|TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeRouterPeer_bfd|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_update|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccClouddeployTarget_Target|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleGlobalForwardingRule|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicy_update

modular-magician · 2022-10-14T05:50:01Z

Tests passed during RECORDING mode:
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeNetworkFirewallPolicy_GlobalHandWritten[Debug log]
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log]
TestAccClouddeployTarget_Target[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccComputeFirewallPolicy_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeRegionalNetworkFirewallPolicy_RegionalHandWritten[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-14T14:23:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 33 files changed, 4483 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 35 files changed, 4992 insertions(+), 157 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

modular-magician · 2022-10-14T15:03:09Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 33 files changed, 4483 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 35 files changed, 4992 insertions(+), 157 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

modular-magician · 2022-10-14T16:14:27Z

Tests analytics

Total tests: 2192
Passed tests 1905
Skipped tests: 239
Failed tests: 48

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionalNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeRegionalNetworkFirewallPolicy_RegionalHandWritten|TestAccComputeRegionalNetworkFirewallPolicyAssociation_RegionalHandWritten|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccBillingSubaccount_renameOnDestroy|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccDataSourceGoogleGlobalForwardingRule|TestAccComputeForwardingRule_ip|TestAccDataSourceGoogleForwardingRule|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyRule_multipleRules

modular-magician · 2022-10-14T17:18:01Z

Tests passed during RECORDING mode:
TestAccComputeVpnTunnel_regionFromGateway[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionalNetworkFirewallPolicy_RegionalHandWritten[Debug log]
TestAccComputeRegionalNetworkFirewallPolicyAssociation_RegionalHandWritten[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]
TestAccBillingSubaccount_renameOnDestroy[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log]
TestAccComputeFirewallPolicyAssociation_basic[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson

As mentioned in chat / noted inline, there's some upgrade difficulties that are going to block merging after initial review.

Additionally, would it be possible to break this into 3 sequential PRs, one per base resource? It's my experience that review time is pretty much exponential with the number of new resources, so keeping to 1 resource (or 1 base resource w/ locational resources like this) tends to go much faster. That'll let us work out the generator changes + network_firewall_policy/its regional variant before worrying about the other two, which are likely to be pretty routine.

mmv1/third_party/terraform/go.mod.erb

tpgtools/overrides/compute/beta/network_firewall_policy.yaml

… region in name

modular-magician · 2022-10-15T03:05:42Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 21 files changed, 1390 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 23 files changed, 1899 insertions(+), 157 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

modular-magician · 2022-10-15T04:10:08Z

Tests analytics

Total tests: 2193
Passed tests 1926
Skipped tests: 239
Failed tests: 28

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeRegionNetworkFirewallPolicy_RegionalHandWritten|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleForwardingRule|TestAccComputeFirewallPolicyRule_update

modular-magician · 2022-10-15T04:17:56Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRegionNetworkFirewallPolicy_RegionalHandWritten[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_ipv6[Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log]
TestAccComputeGlobalForwardingRule_updateTarget[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccDataSourceGoogleGlobalForwardingRule[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_defaultTrafficSelectors[Error message] [Debug log]
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-19T14:04:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 1390 insertions(+), 42 deletions(-))
Terraform Beta: Diff ( 23 files changed, 1899 insertions(+), 157 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 10 deletions(-))

modular-magician · 2022-10-19T14:57:00Z

Tests analytics

Total tests: 2198
Passed tests 1949
Skipped tests: 239
Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeForwardingRule_update|TestAccDataSourceGoogleForwardingRule

modular-magician · 2022-10-19T15:05:05Z

Tests passed during RECORDING mode:
TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccDataSourceGoogleForwardingRule[Debug log]

Tests failed during RECORDING mode:
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…l field

…field in beta

This reverts commit e3a4a13.

modular-magician · 2022-11-07T22:00:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1274 insertions(+), 29 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1276 insertions(+), 31 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-07T22:38:57Z

Tests analytics

Total tests: 2224
Passed tests 1983
Skipped tests: 240
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-11-07T22:39:24Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

rileykarson

Looks like we're not testing update here, even though the resource supports it. We should be able to port over https://github.com/GoogleCloudPlatform/declarative-resource-client-library/blob/main/services/google/compute/samples/regional_network_firewall_policy.yaml? I see that we're not using sample generation though- I'm assuming it doesn't work with multi-location resources?

It's honestly probably easiest to handwrite the update test if so: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/README.md#update-tests

modular-magician · 2022-11-07T23:54:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1314 insertions(+), 29 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1316 insertions(+), 31 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-08T00:40:56Z

Tests analytics

Total tests: 2224
Passed tests 1981
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeNetworkFirewallPolicy_GlobalHandWritten|TestAccComputeRegionNetworkFirewallPolicy_RegionalHandWritten

modular-magician · 2022-11-08T00:41:32Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeNetworkFirewallPolicy_GlobalHandWritten[Debug log]
TestAccComputeRegionNetworkFirewallPolicy_RegionalHandWritten[Debug log]

All tests passed
View the build log or the debug log for each test

…olicy (GoogleCloudPlatform#6693) Co-authored-by: Ghaleb Al-habian <galhabian@google.com> Co-authored-by: Angel Montero <angelmontero@google.com> Co-authored-by: Chris Hawk <hawk@google.com>

Ghaleb Al-habian added 3 commits October 13, 2022 22:32

Adding new meta.yaml *Hide fields to better accomodate resources with…

80bef03

… regional and global flavors

fix commented lines

29698b4

adding network_firewall_policy* resources and regional variants

145f8d4

ghabian requested a review from rileykarson as a code owner October 13, 2022 23:12

Ghaleb Al-habian and others added 5 commits October 13, 2022 23:30

updating DCL dependency version

e6bff91

Merge branch 'GoogleCloudPlatform:main' into dcl-nfp-promote

320ead8

updating go.sum hashes

cd9206f

Merge branch 'dcl-nfp-promote' of https://github.com/ghabian/magic-mo…

39232de

…dules into dcl-nfp-promote

Updating TF DCL version

06a2ebb

ghabian marked this pull request as draft October 14, 2022 14:00

Merge branch 'GoogleCloudPlatform:main' into dcl-nfp-promote

78c7ebc

bring beta nfp overrides to parity with ga

e54e1e6

ghabian marked this pull request as ready for review October 14, 2022 17:29

rileykarson reviewed Oct 14, 2022

View reviewed changes

mmv1/third_party/terraform/go.mod.erb Outdated Show resolved Hide resolved

tpgtools/overrides/compute/beta/network_firewall_policy.yaml Outdated Show resolved Hide resolved

ghabian changed the title ~~Add network_firewall_policy* resources~~ Add support for network_firewall_policy and region_network_firewall_policy Oct 15, 2022

reduce scope of branch to only network_firewall_rule, fix regional ->…

b0dc6f8

… region in name

modular-magician requested a review from rileykarson October 15, 2022 02:53

Merge branch 'GoogleCloudPlatform:main' into dcl-nfp-promote

e6e7d2c

Upgrading to DCL 1.26

8b20cbc

rileykarson mentioned this pull request Oct 24, 2022

Add a terraform resource support for Network Firewall Policies hashicorp/terraform-provider-google#12765

Closed

ghabian mentioned this pull request Nov 7, 2022

Upgrade the dcl version to v1.26.0 #6639

Merged

4 tasks

ghabian and others added 9 commits November 7, 2022 16:35

Merge branch 'GoogleCloudPlatform:main' into dcl-nfp-promote

c5676d5

upgrade dcl to v1.26

f1dc895

add clouddeploy test files

e3a4a13

add tags, and monitoring_config

699b01d

Add monitoringConfig to other files

d6ae66b

Add a test for GKEHub servicemesh and exclude Eventarc trigger channe…

e0c9220

…l field

remove monitoring_config in handwritten tests and adding exclude for …

5ea6e13

…field in beta

Revert "add clouddeploy test files"

aa17bdd

This reverts commit e3a4a13.

Merge branch 'GoogleCloudPlatform:main' into dcl-nfp-promote

ce70d6b

rileykarson reviewed Nov 7, 2022

View reviewed changes

adding update tests

b96c861

modular-magician requested a review from rileykarson November 7, 2022 23:41

rileykarson approved these changes Nov 8, 2022

View reviewed changes

rileykarson merged commit 63f0c56 into GoogleCloudPlatform:main Nov 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for network_firewall_policy and region_network_firewall_policy #6693

Add support for network_firewall_policy and region_network_firewall_policy #6693

ghabian commented Oct 13, 2022 •

edited by rileykarson

google-cla bot commented Oct 13, 2022

modular-magician commented Oct 14, 2022

modular-magician commented Oct 14, 2022

modular-magician commented Oct 14, 2022

modular-magician commented Oct 14, 2022

modular-magician commented Oct 14, 2022

modular-magician commented Oct 14, 2022

modular-magician commented Oct 14, 2022

rileykarson left a comment

modular-magician commented Oct 15, 2022

modular-magician commented Oct 15, 2022

modular-magician commented Oct 15, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

rileykarson left a comment •

edited

modular-magician commented Nov 7, 2022

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

Add support for network_firewall_policy and region_network_firewall_policy #6693

Add support for network_firewall_policy and region_network_firewall_policy #6693

Conversation

ghabian commented Oct 13, 2022 • edited by rileykarson

google-cla bot commented Oct 13, 2022

modular-magician commented Oct 14, 2022

Diff report:

modular-magician commented Oct 14, 2022

Tests analytics

Action taken

modular-magician commented Oct 14, 2022

modular-magician commented Oct 14, 2022

Diff report:

modular-magician commented Oct 14, 2022

Diff report:

modular-magician commented Oct 14, 2022

Tests analytics

Action taken

modular-magician commented Oct 14, 2022

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Oct 15, 2022

Diff report:

modular-magician commented Oct 15, 2022

Tests analytics

Action taken

modular-magician commented Oct 15, 2022

modular-magician commented Oct 19, 2022

Diff report

modular-magician commented Oct 19, 2022

Tests analytics

Action taken

modular-magician commented Oct 19, 2022

modular-magician commented Nov 7, 2022

Diff report

modular-magician commented Nov 7, 2022

Tests analytics

Action taken

modular-magician commented Nov 7, 2022

rileykarson left a comment • edited

Choose a reason for hiding this comment

modular-magician commented Nov 7, 2022

Diff report

modular-magician commented Nov 8, 2022

Tests analytics

Action taken

modular-magician commented Nov 8, 2022

ghabian commented Oct 13, 2022 •

edited by rileykarson

rileykarson left a comment •

edited