feat(google_container_cluster): promote cost allocation to GA

[bradhoekstra]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Promote `enable_cost_allocation` field in `google_container_cluster` to GA

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[bradhoekstra]

Looks like I have to wait for google.golang.org/api/container/v1 to pick up this field.

[slevenick]

Looks like this fails to compile with errors such as:
undefined: container.CostManagementConfig

Can you generate & compile the GA version of the provider locally?

[slevenick]

Oh, missed your comment, it depends on a new version of the client libraries to be released. Please re-request review once that is ready

[slevenick]

Re-request review once the new client library is released.

This will also need the docs for this field to be updated to not say beta only

[slevenick]

Hm, something went wrong with the library upgrade, it wants go mod tidy to be run

[bradhoekstra]

Ya, I'm trying to figure that out. First time doing this though, so figuring everything out is slow :)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 143 insertions(+), 109 deletions(-))
Terraform Beta: Diff ( 3 files changed, 30 insertions(+), 106 deletions(-))
TF Validator: Diff ( 2 files changed, 33 insertions(+), 32 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2200
Passed tests 1960
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[bradhoekstra]

@slevenick : All checks are passing now.

[bradhoekstra]

Fixed go modules.

[slevenick]

It looks like this field is missing documentation in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown

Can you add it there? I would ask you to just remove the beta flag on it, but it seems like it was missed when it was initially added

[bradhoekstra]

Thanks for the pointer @slevenick, I've updated the docs now.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 151 insertions(+), 109 deletions(-))
Terraform Beta: Diff ( 4 files changed, 38 insertions(+), 106 deletions(-))
TF Validator: Diff ( 2 files changed, 33 insertions(+), 32 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2200
Passed tests 1958
Skipped tests: 239
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[slevenick]

Thanks!