fix endpoint for non-global

[edwardmedia]

Fixes hashicorp/terraform-provider-google#12880

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dialogflowcx: fixed a deployment issue for `google_dialogflow_cx_version` and `google_dialogflow_cx_environment` when they are deployed to a non-global location

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 200 insertions(+), 569 deletions(-))
Terraform Beta: Diff ( 10 files changed, 200 insertions(+), 569 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1966
Skipped tests: 239
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXVersion_update|TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample|TestAccDialogflowCXEnvironment_update|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccDialogflowCXVersion_dialogflowcxVersionFullExample[Debug log]
TestAccDialogflowCXVersion_update[Debug log]
TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample[Debug log]
TestAccDialogflowCXEnvironment_update[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

[shuyama1]

LGTM overall! I think we still need to manually copy the documentation file. Also can we add a regional test to check if the fix works?

[edwardmedia]

Updated & added. Thanks @shuyama1

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 257 insertions(+), 444 deletions(-))
Terraform Beta: Diff ( 10 files changed, 257 insertions(+), 444 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2236
Passed tests 1992
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentRegional|TestAccComputeForwardingRule_update|TestAccDataSourceGoogleServiceAccountIdToken_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentRegional[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_basic[Debug log]

All tests passed
View the build log or the debug log for each test

[shuyama1]

Thanks for adding the test! Looks like we still need documentaiton for dialogflow_cx_version

[edwardmedia]

Good call @shuyama1

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 257 insertions(+), 308 deletions(-))
Terraform Beta: Diff ( 10 files changed, 257 insertions(+), 308 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2236
Passed tests 1995
Skipped tests: 241
Failed tests: 0

All tests passed in REPLAYING mode
View the build log